[Filestore] Handle requests with three-stage write disabled in TWriteDataActor#6404
Conversation
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 255s): all tests PASSED for commit 7d25bd3.
|
antonmyagkov
added
the
filestore
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🔴 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4377s): some tests FAILED for commit 7d25bd3.
🔴 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 46s): some tests FAILED for commit 7d25bd3.
🔴 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 39s): some tests FAILED for commit 7d25bd3.
|
antonmyagkov
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d25bd3fbc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🔴 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4565s): some tests FAILED for commit 0423585.
🔴 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 41s): some tests FAILED for commit 0423585.
🔴 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 37s): some tests FAILED for commit 0423585.
|
antonmyagkov
added
the
rebase
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. |
0423585 to
7b32ca7
Compare
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4612s): all tests PASSED for commit 7b32ca7.
|
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4532s): all tests PASSED for commit 5cedf65.
|
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. |
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5123s): all tests PASSED for commit f17ff90.
|
3 participants
prefactoring for issue: #6334
Handle requests with three-stage write disabled in TWriteDataActor to avoid copying iovecs into a buffer in the singleton TStorageServiceActor.
The 1 MiB FIO tests showed a significant improvement in write bandwidth, increasing from 3 GiB/s to 7.3 GiB/s.