Claude/setup docs planning im7e v#3
Merged
Conversation
- Replace ObservableObject/@Published/@StateObject with the Observation framework (@observable + @State + @bindable). - Annotate PreferencesViewModel as @mainactor so timer callbacks and UserDefaults access are isolated to the main actor. - Drop @AppStorage from the view model; read autoRefreshSpaces directly from UserDefaults in init(). @AppStorage is a SwiftUI DynamicProperty and is not reliable inside an @observable class. - Dispatch the Timer tick through Task { @mainactor in } so the refreshSpaces() call is cleanly isolated. - Bump SWIFT_VERSION from 5.0 to 5.10 across both targets (debug and release) so Observation macros are available.
NSImage.lockFocus()/unlockFocus() mutates global graphics state and is error-prone: forgetting unlockFocus() corrupts subsequent drawing, and mixing with concurrent rendering is unsafe. Apple recommends NSImage(size:flipped:drawingHandler:) for new code. Rewrite every icon composition site in IconCreator to use the block-based initializer. isTemplate = true is still set on the resulting image (it applies to the wrapper, not the draw block). Behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.