Tweak $location decorator and visit(); all tests pass.#16
Closed
wardbell wants to merge 1 commit into
Closed
Conversation
wardbell
commented
Nov 15, 2014
- Guard against infinite $location.path loop as explained in comment
- Give visit() one more tick before it invokes the callback; determined empirically that this is necessary on occasion else the viewElement() may return empty object
- Guard against infinite $location.path loop as explained in comment - Give visit() one more tick before it invokes the callback; determined empirically that this is necessary on occasion else the viewElement() may return empty object
Author
|
You may prefer the stabilize approach in gaelazzo's pull request as it is less of a hacky guess than mine. Something has to be done because I'm running into the exact same problem he describes. The infinite loop problem can be revealed when a route has a |
Author
|
I think we can safely let this die ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.