Add Transformers.Compact for non-indented XML output (#54)#304
Open
bibonix wants to merge 9 commits intoyegor256:masterfrom
Open
Add Transformers.Compact for non-indented XML output (#54)#304bibonix wants to merge 9 commits intoyegor256:masterfrom
bibonix wants to merge 9 commits intoyegor256:masterfrom
Conversation
Tests demonstrate the need for a Compact transformer that disables pretty-printing while keeping the XML declaration.
Introduces a new Transformers.Compact class that produces XML output with the XML declaration but without pretty-printing (no indentation). This gives users an easy way to switch pretty-print OFF, parallel to the existing Document (declaration + indent) and Node (no declaration + indent) transformer factories.
The 0.23.2 maven plugin version references docker image `yegor256/hone:0.23.2` which is not published on Docker Hub, causing every CI build with docker available to fail at the `hone:pull` step. Version 0.23.3 has a matching docker image.
The hone-maven-plugin's `skipWithoutDocker` only checks if the docker binary exists, not whether the daemon is running. macOS GH runners have the docker binary but no running daemon, causing the `hone:pull` step to fail before any tests run. Pass `-Dhone.skip=true` from the workflow to bypass it consistently across all matrix entries (Linux still runs the optimization in the rultor merge build).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54.
Adds a new
Transformers.Compactclass that produces XML output without pretty-printing (no indentation), while keeping the XML declaration. This is parallel to the existingTransformers.Document(with declaration and indent) andTransformers.Node(without declaration but indented).Users can now disable pretty printing with:
New tests cover the Compact behavior as well as the existing Document and Node behaviors.