refactor: errorPairPtr to errorPair

Author: uri-99

aggregator/pkg/subscriber.go

@@ -3,18 +3,18 @@ package pkg
 import "github.com/yetanotherco/aligned_layer/core/chainio"
 
 func (agg *Aggregator) SubscribeToNewTasks() *chainio.ErrorPair {
-	errorPairPtr := agg.subscribeToNewTasks()
-	if errorPairPtr != nil {
-		return errorPairPtr
+	errorPair := agg.subscribeToNewTasks()
+	if errorPair != nil {
+		return errorPair
 	}
 
 	for {
 		select {
 		case err := <-agg.taskSubscriber:
 			agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to subscribe to new tasks", "err", err)
-			errorPairPtr = agg.subscribeToNewTasks()
-			if errorPairPtr != nil {
-				return errorPairPtr
+			errorPair = agg.subscribeToNewTasks()
+			if errorPair != nil {
+				return errorPair
 			}
 		case newBatch := <-agg.NewBatchChan:
 			agg.AggregatorConfig.BaseConfig.Logger.Info("Adding new task")
@@ -24,11 +24,11 @@ func (agg *Aggregator) SubscribeToNewTasks() *chainio.ErrorPair {
 }
 
 func (agg *Aggregator) subscribeToNewTasks() *chainio.ErrorPair {
-	errorPairPtr := agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan, agg.taskSubscriber)
+	errorPair := agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan, agg.taskSubscriber)
 
-	if errorPairPtr != nil {
-		agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", errorPairPtr)
+	if errorPair != nil {
+		agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", errorPair)
 	}
 
-	return errorPairPtr
+	return errorPair
 }

operator/pkg/operator.go

@@ -207,14 +207,14 @@ func (o *Operator) UpdateLastProcessBatch(blockNumber uint32) error {
 func (o *Operator) Start(ctx context.Context) error {
 	// create a new channel to foward errors
 	subV2ErrorChannel := make(chan chainio.ErrorPair)
-	errorPairPtr := o.SubscribeToNewTasksV2(subV2ErrorChannel)
-	if errorPairPtr != nil {
+	errorPair := o.SubscribeToNewTasksV2(subV2ErrorChannel)
+	if errorPair != nil {
 		log.Fatal("Could not subscribe to new tasks")
 	}
 
 	subV3ErrorChannel := make(chan chainio.ErrorPair)
-	errorPairPtr = o.SubscribeToNewTasksV3(subV3ErrorChannel)
-	if errorPairPtr != nil {
+	errorPair = o.SubscribeToNewTasksV3(subV3ErrorChannel)
+	if errorPair != nil {
 		log.Fatal("Could not subscribe to new tasks")
 	}
 
@@ -236,14 +236,14 @@ func (o *Operator) Start(ctx context.Context) error {
 			o.Logger.Errorf("Metrics server failed", "err", err)
 		case errorPair := <-subV2ErrorChannel:
 			o.Logger.Infof("Error in websocket subscription", "err", errorPair)
-			errorPairPtr = o.SubscribeToNewTasksV2(subV2ErrorChannel)
-			if errorPairPtr != nil {
+			errorPair = o.SubscribeToNewTasksV2(subV2ErrorChannel)
+			if errorPair != nil {
 				o.Logger.Fatal("Could not subscribe to new tasks V2")
 			}
 		case errorPair := <-subV3ErrorChannel:
 			o.Logger.Infof("Error in websocket subscription", "err", errorPair)
-			errorPairPtr = o.SubscribeToNewTasksV3(subV3ErrorChannel)
-			if errorPairPtr != nil {
+			errorPair = o.SubscribeToNewTasksV3(subV3ErrorChannel)
+			if errorPair != nil {
 				o.Logger.Fatal("Could not subscribe to new tasks V3")
 			}
 		case newBatchLogV2 := <-o.NewTaskCreatedChanV2: