refactor tests

Author: PatStiles

core/utils/eth_client_utils.go

@@ -31,7 +31,19 @@ func WaitForTransactionReceiptRetryable(client eth.InstrumentedClient, fallbackC
 		}
 		return receipt, nil
 	}
-	return retry.RetryWithData(receipt_func, config)
+	return receipt_func
+}
+
+// WaitForTransactionReceiptRetryable repeatedly attempts to fetch the transaction receipt for a given transaction hash.
+// If the receipt is not found, the function will retry with exponential backoff until the specified `waitTimeout` duration is reached.
+// If the receipt is still unavailable after `waitTimeout`, it will return an error.
+//
+// Note: The `time.Second * 2` is set as the max interval in the retry mechanism because we can't reliably measure the specific time the tx will be included in a block.
+// Setting a higher value will imply doing less retries across the waitTimeout, and so we might lose the receipt
+// All errors are considered Transient Errors
+// - Retry times: 0.5s, 1s, 2s, 2s, 2s, ... until it reaches waitTimeout
+func WaitForTransactionReceiptRetryable(client eth.InstrumentedClient, fallbackClient eth.InstrumentedClient, txHash gethcommon.Hash, config *retry.RetryConfig) (*types.Receipt, error) {
+	return retry.RetryWithData(WaitForTransactionReceipt(client, fallbackClient, txHash, config), config)
 }
 
 func BytesToQuorumNumbers(quorumNumbersBytes []byte) eigentypes.QuorumNums {