Skip to content

Commit 64e1f48

Browse files
committed
test works
1 parent 34f78c4 commit 64e1f48

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

core/retry_test.go

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -952,12 +952,10 @@ func TestSendSignedTaskResponse(t *testing.T) {
952952
logger := operatorConfig.BaseConfig.Logger
953953
rpcClient, err := operator.NewAggregatorRpcClient(operatorConfig.Operator.AggregatorServerIpPortAddress, logger)
954954
// This is a mock to verify that a lost connection to the aggregator does not return anything.
955-
/*
956-
disconnected_rpcClient, err := operator.NewAggregatorRpcClient("localhost:8999", logger)
957-
if err != nil {
958-
fmt.Errorf("Could not create RPC client: %s. Is aggregator running?", err)
959-
}
960-
*/
955+
disconnected_rpcClient, err := operator.NewAggregatorRpcClient("localhost:8999", logger)
956+
if err != nil {
957+
fmt.Errorf("Could not create RPC client: %s. Is aggregator running?", err)
958+
}
961959

962960
signedTaskResponse := &core_types.SignedTaskResponse{
963961
BatchIdentifierHash: [32]byte{},
@@ -971,16 +969,19 @@ func TestSendSignedTaskResponse(t *testing.T) {
971969
_, err = task_resp_func()
972970
assert.Nil(t, err)
973971

972+
fmt.Printf("stuff")
973+
task_resp_func = operator.SendSignedTaskResponse(disconnected_rpcClient, signedTaskResponse)
974+
// NOTE: Stopping the handler via the go handle does not work due to a context not being passed to the aggregator here: https://github.com/yetanotherco/aligned_layer/blob/staging/aggregator/pkg/aggregator.go#L220
975+
// NOTE: This the expected behavior of a net/rpc/clint/Go for an invalid connection ref: https://cs.opensource.google/go/go/+/refs/tags/go1.23.3:src/net/rpc/client.go;l=298
976+
assert.Panics(t, func() { _, err = task_resp_func() })
977+
978+
task_resp_func = operator.SendSignedTaskResponse(rpcClient, signedTaskResponse)
979+
_, err = task_resp_func()
980+
assert.Nil(t, err)
981+
974982
// Kill Aggregator
975983
cancel()
976984

977-
/*
978-
fmt.Printf("stuff")
979-
task_resp_func = operator.SendSignedTaskResponse(disconnected_rpcClient, signedTaskResponse)
980-
// NOTE: This the expected behavior of a net/rpc/clint/Go for an invalid connection ref: https://cs.opensource.google/go/go/+/refs/tags/go1.23.3:src/net/rpc/client.go;l=298
981-
assert.Panics(t, func() { _, err = task_resp_func() })
982-
*/
983-
984985
if err = cmd.Process.Kill(); err != nil {
985986
t.Errorf("Error killing process: %v\n", err)
986987
return

0 commit comments

Comments
 (0)