test works

Author: PatStiles

core/retry_test.go

@@ -952,12 +952,10 @@ func TestSendSignedTaskResponse(t *testing.T) {
 	logger := operatorConfig.BaseConfig.Logger
 	rpcClient, err := operator.NewAggregatorRpcClient(operatorConfig.Operator.AggregatorServerIpPortAddress, logger)
 	// This is a mock to verify that a lost connection to the aggregator does not return anything.
-	/*
-		disconnected_rpcClient, err := operator.NewAggregatorRpcClient("localhost:8999", logger)
-		if err != nil {
-			fmt.Errorf("Could not create RPC client: %s. Is aggregator running?", err)
-		}
-	*/
+	disconnected_rpcClient, err := operator.NewAggregatorRpcClient("localhost:8999", logger)
+	if err != nil {
+		fmt.Errorf("Could not create RPC client: %s. Is aggregator running?", err)
+	}
 
 	signedTaskResponse := &core_types.SignedTaskResponse{
 		BatchIdentifierHash: [32]byte{},
@@ -971,16 +969,19 @@ func TestSendSignedTaskResponse(t *testing.T) {
 	_, err = task_resp_func()
 	assert.Nil(t, err)
 
+	fmt.Printf("stuff")
+	task_resp_func = operator.SendSignedTaskResponse(disconnected_rpcClient, signedTaskResponse)
+	// NOTE: Stopping the handler via the go handle does not work due to a context not being passed to the aggregator here: https://github.com/yetanotherco/aligned_layer/blob/staging/aggregator/pkg/aggregator.go#L220
+	// NOTE: This the expected behavior of a net/rpc/clint/Go for an invalid connection ref: https://cs.opensource.google/go/go/+/refs/tags/go1.23.3:src/net/rpc/client.go;l=298
+	assert.Panics(t, func() { _, err = task_resp_func() })
+
+	task_resp_func = operator.SendSignedTaskResponse(rpcClient, signedTaskResponse)
+	_, err = task_resp_func()
+	assert.Nil(t, err)
+
 	// Kill Aggregator
 	cancel()
 
-	/*
-		fmt.Printf("stuff")
-		task_resp_func = operator.SendSignedTaskResponse(disconnected_rpcClient, signedTaskResponse)
-		// NOTE: This the expected behavior of a net/rpc/clint/Go for an invalid connection ref: https://cs.opensource.google/go/go/+/refs/tags/go1.23.3:src/net/rpc/client.go;l=298
-		assert.Panics(t, func() { _, err = task_resp_func() })
-	*/
-
 	if err = cmd.Process.Kill(); err != nil {
 		t.Errorf("Error killing process: %v\n", err)
 		return