Skip to content

refactor: add missing functions to contract interface #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MauroToscano merged 7 commits into from
Mar 18, 2025
Merged

refactor: add missing functions to contract interface #1773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
888708d
refactor: add missing functions to IAligned....sol
uri-99 Jan 21, 2025
97dc3f1
refactor: undo signature changes on checkPublicInput
JuArce Feb 10, 2025
1f7218c
fix: update IAlignedLayerServiceManager.sol
JuArce Feb 10, 2025
306f2ea
fix: update IAlignedLayerServiceManager.sol
JuArce Feb 10, 2025
d106151
Merge branch 'refs/heads/staging' into 1771-refactorcontract-update-i…
JuArce Mar 18, 2025
228f40c
fix: update anvil state
JuArce Mar 18, 2025
43778a3
Merge branch 'staging' into 1771-refactorcontract-update-ialignedsol-…
MauroToscano Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion contracts/src/core/AlignedLayerServiceManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ contract AlignedLayerServiceManager is
function checkPublicInput(
bytes calldata publicInput,
bytes32 hash
) public pure returns (bool) {
) external pure returns (bool) {
return keccak256(publicInput) == hash;
}
Copy link
Copy Markdown
Contributor

@MauroToscano MauroToscano Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, but it's mostly to reduce a bit the cost, right ?

Copy link
Copy Markdown
Collaborator

@JuArce JuArce Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is. We don't use this function in the contract, so it can be external.


Expand Down
6 changes: 6 additions & 0 deletions contracts/src/core/IAlignedLayerServiceManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,10 @@ interface IAlignedLayerServiceManager {
function enableVerifier(uint8 verifierIdx) external;

function setDisabledVerifiers(uint256 bitmap) external;

function withdraw(uint256 amount) external;

function depositToBatcher(address account) external payable;

function checkPublicInput(bytes calldata publicInput, bytes32 hash) external pure returns (bool);
}