Cache LDE from Round 1 to skip recomputation in Rounds 2-4#492
Merged
Conversation
Collaborator
Author
|
/bench |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Benchmark — fib_iterative_8M (median of 3)Table parallelism: 32 (auto = cores / 3)
Commit: 97e0e91 · Baseline: built from main · Runner: self-hosted bench |
gabrielbosio
force-pushed
the
feat/cache-lde-round1
branch
from
April 13, 2026 21:24
5626d8b to
9135f11
Compare
gabrielbosio
marked this pull request as ready for review
April 13, 2026 21:25
diegokingston
approved these changes
Apr 14, 2026
MauroToscano
requested changes
Apr 14, 2026
MauroToscano
left a comment
MauroToscano
left a comment
Contributor
There was a problem hiding this comment.
Pool shouldn't be needed now, since it's being emptied all the time. We can remove all the complexity of that code and only use the cache
Collaborator
Author
Done in #498 |
Collaborator
Author
|
/bench |
* Simplification * Rename metadata -> cache * Rework * CacheLDE -> LDE * Drop has_aux_trace param from build_round1 * Route reconstruct_round1 through build_round1 * Revert "Drop has_aux_trace param from build_round1" This reverts commit 164c7c0. * Pass has_aux_trace to build_round1 from reconstruct_round1 --------- Co-authored-by: gabrielbosio <gabrielbosio95@gmail.com>
Collaborator
Author
|
/bench |
MauroToscano
approved these changes
Apr 15, 2026
MauroToscano
enabled auto-merge
April 15, 2026 20:22
jotabulacios
pushed a commit
that referenced
this pull request
Apr 16, 2026
* Cache LDE from Round 1 to skip recomputation in Rounds 2-4 * Remove timing profile script (moved to separate PR) * Document memory trade-off, fix expect messages * Fix stale trace_lde comment in prove_rounds_2_to_4 * Remove dead trace_lde telemetry field * Remove LDE column pool, commit functions own their buffers (#498) * Simplification (#500) * Simplification * Rename metadata -> cache * Rework * CacheLDE -> LDE * Drop has_aux_trace param from build_round1 * Route reconstruct_round1 through build_round1 * Revert "Drop has_aux_trace param from build_round1" This reverts commit 164c7c0. * Pass has_aux_trace to build_round1 from reconstruct_round1 --------- Co-authored-by: gabrielbosio <gabrielbosio95@gmail.com> --------- Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.