refactor!: remove AttributeOrProperty::Static workaround for Rust <1.72

BREAKING CHANGE: removed the `Static` variant from the public
`AttributeOrProperty` enum.

Author: Madoshakalaka

packages/yew-macro/src/html_tree/html_element.rs

@@ -302,8 +302,8 @@ impl ToTokens for HtmlElement {
                                 ::std::convert::Into::into(#v)
                             ))
                         }
-                        None => quote!(::yew::virtual_dom::AttributeOrProperty::Static(
-                            #v
+                        None => quote!(::yew::virtual_dom::AttributeOrProperty::Attribute(
+                            ::yew::virtual_dom::AttrValue::Static(#v)
                         )),
                     };
                     kv.push(quote! { ( #k, #v) });

packages/yew/src/dom_bundle/btag/attributes.rs

@@ -173,9 +173,6 @@ impl Attributes {
             AttributeOrProperty::Attribute(value) => el
                 .set_attribute(intern(key), value)
                 .expect("invalid attribute key"),
-            AttributeOrProperty::Static(value) => el
-                .set_attribute(intern(key), value)
-                .expect("invalid attribute key"),
             AttributeOrProperty::Property(value) => {
                 let key = JsValue::from_str(key);
                 js_sys::Reflect::set(el.as_ref(), &key, value).expect("could not set property");
@@ -185,7 +182,7 @@ impl Attributes {
 
     fn remove(el: &Element, key: &str, old_value: &AttributeOrProperty) {
         match old_value {
-            AttributeOrProperty::Attribute(_) | AttributeOrProperty::Static(_) => el
+            AttributeOrProperty::Attribute(_) => el
                 .remove_attribute(intern(key))
                 .expect("could not remove attribute"),
             AttributeOrProperty::Property(_) => {
@@ -364,7 +361,10 @@ mod tests {
 
     #[test]
     fn class_is_always_attrs() {
-        let attrs = Attributes::Static(&[("class", AttributeOrProperty::Static("thing"))]);
+        let attrs = Attributes::Static(&[(
+            "class",
+            AttributeOrProperty::Attribute(AttrValue::Static("thing")),
+        )]);
 
         let (element, btree) = create_element();
         attrs.apply(&btree, &element);

packages/yew/src/virtual_dom/mod.rs

@@ -179,13 +179,6 @@ mod feat_ssr {
 #[expect(missing_docs)]
 #[derive(PartialEq, Clone, Debug)]
 pub enum AttributeOrProperty {
-    // This exists as a workaround to support Rust <1.72
-    // Previous versions of Rust did not See
-    // `AttributeOrProperty::Attribute(AttrValue::Static(_))` as `'static` that html! macro
-    // used, and thus failed with "temporary value dropped while borrowed"
-    //
-    // See: https://github.com/yewstack/yew/pull/3458#discussion_r1350362215
-    Static(&'static str),
     Attribute(AttrValue),
     Property(JsValue),
 }
@@ -233,7 +226,6 @@ impl Attributes {
             Self::Static(arr) => Box::new(arr.iter().filter_map(|(k, v)| match v {
                 AttributeOrProperty::Attribute(v) => Some((*k, v.as_ref())),
                 AttributeOrProperty::Property(_) => None,
-                AttributeOrProperty::Static(v) => Some((*k, v)),
             })),
             Self::Dynamic { keys, values } => {
                 Box::new(keys.iter().zip(values.iter()).filter_map(|(k, v)| match v {