merge master; fix VList PartialEq; extract implicit-clone as workspace dep

Author: Madoshakalaka

Cargo.lock

@@ -30,3 +30,4 @@ unexpected_cfgs = { level = "warn", check-cfg = [
 ]}
 [workspace.dependencies]
 tokio = { version = "1.47.1" }
+implicit-clone = { version = "0.5.1" }

Cargo.toml

@@ -6,7 +6,7 @@ edition = "2021"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-implicit-clone = { version = "0.5", features = ["map"] }
+implicit-clone = { workspace = true, features = ["map"] }
 wasm-bindgen = "0.2"
 web-sys = "0.3"
 yew = { path = "../../packages/yew", features = ["csr"] }

examples/immutable/Cargo.toml

@@ -6,7 +6,7 @@ edition = "2021"
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-implicit-clone = "0.4"
+implicit-clone = { workspace = true }
 log = "0.4"
 wasm-logger = "0.2"
 yew = { path = "../../packages/yew", features = ["csr"] }

examples/nested_list/Cargo.toml

@@ -472,7 +472,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<implicit_clone:
              `&'static str` implements `IntoPropValue<Option<implicit_clone::unsync::string::IString>>`
              `&'static str` implements `IntoPropValue<String>`
              `&'static str` implements `IntoPropValue<implicit_clone::unsync::string::IString>`
-             `&String` implements `IntoPropValue<VNode>`
+             `&ChildrenRenderer<VNode>` implements `IntoPropValue<VNode>`
            and $N others
 
 error[E0277]: the trait bound `Option<NotToString>: IntoPropValue<Option<implicit_clone::unsync::string::IString>>` is not satisfied
@@ -672,7 +672,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<implicit_clone:
              `&'static str` implements `IntoPropValue<Option<implicit_clone::unsync::string::IString>>`
              `&'static str` implements `IntoPropValue<String>`
              `&'static str` implements `IntoPropValue<implicit_clone::unsync::string::IString>`
-             `&String` implements `IntoPropValue<VNode>`
+             `&ChildrenRenderer<VNode>` implements `IntoPropValue<VNode>`
            and $N others
 
 error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied

packages/yew-macro/tests/html_macro/element-fail.stderr

@@ -3,7 +3,6 @@ use std::ops::{Deref, DerefMut};
 use std::rc::Rc;
 
 use super::{Key, VNode};
-use crate::html::ImplicitClone;
 
 #[doc(hidden)]
 #[derive(Clone, Copy, Debug, PartialEq)]
@@ -27,7 +26,16 @@ pub struct VList {
 
 impl PartialEq for VList {
     fn eq(&self, other: &Self) -> bool {
-        self.key == other.key && self.children == other.children
+        if self.key != other.key {
+            return false;
+        }
+
+        match (self.children.as_ref(), other.children.as_ref()) {
+            (Some(a), Some(b)) => a == b,
+            (Some(a), None) => a.is_empty(),
+            (None, Some(b)) => b.is_empty(),
+            (None, None) => true,
+        }
     }
 }