Optimize VList creation from ref ChildrenRenderer

cecton · cecton · commit fc402b113bda · 2023-11-06T08:10:37.000+01:00
diff --git a/packages/yew/src/html/conversion/into_prop_value.rs b/packages/yew/src/html/conversion/into_prop_value.rs
@@ -170,7 +170,10 @@ impl IntoPropValue<VNode> for ChildrenRenderer<VNode> {
 impl IntoPropValue<VNode> for &ChildrenRenderer<VNode> {
     #[inline]
     fn into_prop_value(self) -> VNode {
-        VNode::VList(Rc::new(self.clone().into()))
+        VNode::VList(Rc::new(VList::with_children(
+            self.children.iter().cloned().collect(),
+            None,
+        )))
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,10 @@ impl IntoPropValue<VNode> for ChildrenRenderer<VNode> {`
`170`	`170`	`impl IntoPropValue<VNode> for &ChildrenRenderer<VNode> {`
`171`	`171`	`#[inline]`
`172`	`172`	`fn into_prop_value(self) -> VNode {`
`173`		`- VNode::VList(Rc::new(self.clone().into()))`
	`173`	`+ VNode::VList(Rc::new(VList::with_children(`
	`174`	`+ self.children.iter().cloned().collect(),`
	`175`	`+ None,`
	`176`	`+ )))`
`174`	`177`	`}`
`175`	`178`	`}`
`176`	`179`