key: avoid string copy for From<String> implementation#3858
Merged
Conversation
The macro uses `to_string().as_str()` which copies the string. Avoid that by using `as_str()` directly on the source. Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
|
Visit the preview URL for this PR (updated for commit 35897d5): https://yew-rs-api--pr3858-key-from-string-dqgjd4n5.web.app (expires Tue, 20 May 2025 07:04:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
WorldSEnder
approved these changes
May 13, 2025
Member
WorldSEnder
left a comment
There was a problem hiding this comment.
Clear and simple, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macro uses
to_string().as_str()which copies the string. Avoid that by usingas_str()directly on the source.Description
Omits one string copy for
From<String>Checklist