Skip to content

Maintain some nightly features and CI#3934

Merged
WorldSEnder merged 4 commits into
yewstack:masterfrom
WorldSEnder:fix-nightly
Oct 22, 2025
Merged

Maintain some nightly features and CI#3934
WorldSEnder merged 4 commits into
yewstack:masterfrom
WorldSEnder:fix-nightly

Conversation

@WorldSEnder
Copy link
Copy Markdown
Member

Adjust some nightly features used in documenting and CI.

  • removed doc_auto_cfg in favor of doc_cfg which is already present

  • I have reviewed my own code

removed in favor of `doc_cfg` which is already present
github-actions[bot]
github-actions Bot previously approved these changes Oct 22, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 22, 2025

Visit the preview URL for this PR (updated for commit 2e2b2a2):

https://yew-rs-api--pr3934-fix-nightly-fny43ow1.web.app

(expires Wed, 29 Oct 2025 10:58:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 22, 2025

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.36 ns       │ 3.65 ns       │ 2.364 ns      │ 2.518 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.36 ns       │ 3.202 ns      │ 2.364 ns      │ 2.378 ns      │ 100     │ 1000000000

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 22, 2025

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 290.932 292.204 291.189 0.370
Hello World 10 490.651 500.471 495.287 3.623
Function Router 10 1601.855 1619.738 1608.560 5.648
Concurrent Task 10 1005.719 1007.106 1006.607 0.400
Many Providers 10 1106.116 1139.419 1116.131 11.022

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.008 292.623 291.321 0.466
Hello World 10 479.821 491.152 484.133 3.948
Function Router 10 1600.401 1638.332 1617.469 11.504
Concurrent Task 10 1006.161 1007.834 1006.894 0.512
Many Providers 10 1105.874 1184.608 1133.474 22.770

the fix targets the change to panic_abort in rust-lang/rust#146974
Incidentally, this led me to realize that some RUSTFLAGS were being
ignored, due to the exclusivity of env variables vs config options (see ref).
With this change, all config options are read from toml files instead of
env variables.

reference: https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags
github-actions[bot]
github-actions Bot previously approved these changes Oct 22, 2025
github-actions[bot]
github-actions Bot previously approved these changes Oct 22, 2025
github-actions[bot]
github-actions Bot previously approved these changes Oct 22, 2025
@github-actions
Copy link
Copy Markdown

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 132.811 98.325 -34.485 -25.966%
boids 195.948 167.644 -28.305 -14.445%
communication_child_to_parent 116.146 91.488 -24.657 -21.230%
communication_grandchild_with_grandparent 127.966 102.600 -25.366 -19.823%
communication_grandparent_to_grandchild 124.701 98.950 -25.751 -20.650%
communication_parent_to_child 113.772 88.812 -24.961 -21.939%
contexts 132.077 103.931 -28.146 -21.311%
counter 111.414 85.988 -25.426 -22.821%
counter_functional 111.305 86.129 -25.176 -22.619%
dyn_create_destroy_apps 114.654 88.907 -25.747 -22.456%
file_upload 131.680 97.851 -33.829 -25.690%
function_delayed_input 117.051 91.048 -26.003 -22.215%
function_memory_game 197.114 170.111 -27.003 -13.699%
function_router 372.629 330.215 -42.414 -11.382%
function_todomvc 192.849 162.543 -30.306 -15.715%
futures 275.968 237.339 -38.629 -13.998%
game_of_life 130.754 104.080 -26.674 -20.400%
immutable 228.414 194.814 -33.600 -14.710%
inner_html 106.182 79.844 -26.338 -24.805%
js_callback 135.921 107.788 -28.133 -20.698%
keyed_list 230.792 180.234 -50.558 -21.906%
mount_point 110.294 83.180 -27.114 -24.584%
nested_list 140.146 114.258 -25.888 -18.472%
node_refs 118.049 90.825 -27.224 -23.061%
password_strength 1896.520 1751.711 -144.809 -7.635%
portals 118.838 92.810 -26.028 -21.902%
router 345.319 303.848 -41.472 -12.010%
suspense 140.194 112.123 -28.071 -20.023%
timer 113.181 88.080 -25.101 -22.177%
timer_functional 121.404 95.812 -25.592 -21.080%
todomvc 172.213 142.688 -29.525 -17.145%
two_apps 110.520 85.218 -25.302 -22.893%
web_worker_fib 173.402 133.267 -40.136 -23.146%
web_worker_prime 251.447 185.155 -66.292 -26.364%
webgl 111.000 82.509 -28.491 -25.668%

⚠️ The following examples have changed their size significantly:

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 132.811 98.325 -34.485 -25.966%
boids 195.948 167.644 -28.305 -14.445%
communication_child_to_parent 116.146 91.488 -24.657 -21.230%
communication_grandchild_with_grandparent 127.966 102.600 -25.366 -19.823%
communication_grandparent_to_grandchild 124.701 98.950 -25.751 -20.650%
communication_parent_to_child 113.772 88.812 -24.961 -21.939%
contexts 132.077 103.931 -28.146 -21.311%
counter 111.414 85.988 -25.426 -22.821%
counter_functional 111.305 86.129 -25.176 -22.619%
dyn_create_destroy_apps 114.654 88.907 -25.747 -22.456%
file_upload 131.680 97.851 -33.829 -25.690%
function_delayed_input 117.051 91.048 -26.003 -22.215%
function_memory_game 197.114 170.111 -27.003 -13.699%
function_router 372.629 330.215 -42.414 -11.382%
function_todomvc 192.849 162.543 -30.306 -15.715%
futures 275.968 237.339 -38.629 -13.998%
game_of_life 130.754 104.080 -26.674 -20.400%
immutable 228.414 194.814 -33.600 -14.710%
inner_html 106.182 79.844 -26.338 -24.805%
js_callback 135.921 107.788 -28.133 -20.698%
keyed_list 230.792 180.234 -50.558 -21.906%
mount_point 110.294 83.180 -27.114 -24.584%
nested_list 140.146 114.258 -25.888 -18.472%
node_refs 118.049 90.825 -27.224 -23.061%
password_strength 1896.520 1751.711 -144.809 -7.635%
portals 118.838 92.810 -26.028 -21.902%
router 345.319 303.848 -41.472 -12.010%
suspense 140.194 112.123 -28.071 -20.023%
timer 113.181 88.080 -25.101 -22.177%
timer_functional 121.404 95.812 -25.592 -21.080%
todomvc 172.213 142.688 -29.525 -17.145%
two_apps 110.520 85.218 -25.302 -22.893%
web_worker_fib 173.402 133.267 -40.136 -23.146%
web_worker_prime 251.447 185.155 -66.292 -26.364%
webgl 111.000 82.509 -28.491 -25.668%

@WorldSEnder
Copy link
Copy Markdown
Member Author

Note: The sizes for master in the above are a bit fake (too high) since I had to remove a nightly option due to the change in panic_abort but going forward, the options should be fixed.

@WorldSEnder WorldSEnder merged commit bb031eb into yewstack:master Oct 22, 2025
25 checks passed
@WorldSEnder WorldSEnder deleted the fix-nightly branch October 22, 2025 11:08
@WorldSEnder WorldSEnder added A-examples Area: The examples A-ci Area: The continuous integration labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: The continuous integration A-examples Area: The examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant