Skip to content

extract common deps to the workspace manifest#3989

Merged
Madoshakalaka merged 2 commits into
masterfrom
extract-workspace-deps
Feb 18, 2026
Merged

extract common deps to the workspace manifest#3989
Madoshakalaka merged 2 commits into
masterfrom
extract-workspace-deps

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

I tried to make workspace deps featureless and enable features in the memeber crates.

features are only extracted to the root if all member crates uses the same features

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 16, 2026

Visit the preview URL for this PR (updated for commit 420b7c0):

https://yew-rs-api--pr3989-extract-workspace-de-sd2l7plu.web.app

(expires Mon, 23 Feb 2026 07:07:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 16, 2026

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.747 ns      │ 4.058 ns      │ 3.991 ns      │ 3.59 ns       │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.747 ns      │ 4.043 ns      │ 2.752 ns      │ 2.791 ns      │ 100     │ 1000000000

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 16, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.137 292.004 291.418 0.260
Hello World 10 518.206 541.724 521.413 7.245
Function Router 10 1660.714 1681.694 1667.009 6.320
Concurrent Task 10 1005.077 1007.515 1006.497 0.813
Many Providers 10 1124.384 1162.578 1139.091 13.932

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.174 291.526 291.323 0.115
Hello World 10 484.523 496.801 489.113 4.105
Function Router 10 1653.291 1688.388 1665.721 10.635
Concurrent Task 10 1005.602 1007.229 1006.600 0.465
Many Providers 10 1069.400 1130.883 1090.964 20.953

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 16, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 96.753 96.753 0 0.000%
boids 165.414 165.417 +0.003 +0.002%
communication_child_to_parent 89.911 89.912 +0.001 +0.001%
communication_grandchild_with_grandparent 100.955 100.956 +0.001 +0.001%
communication_grandparent_to_grandchild 97.457 97.451 -0.006 -0.006%
communication_parent_to_child 87.330 87.328 -0.002 -0.002%
contexts 102.952 102.952 0 0.000%
counter 84.052 84.053 +0.001 +0.001%
counter_functional 85.426 85.427 +0.001 +0.001%
dyn_create_destroy_apps 87.057 87.058 +0.001 +0.001%
file_upload 96.576 96.576 0 0.000%
function_delayed_input 91.006 91.009 +0.003 +0.003%
function_memory_game 168.944 168.942 -0.002 -0.001%
function_router 326.408 326.413 +0.005 +0.001%
function_todomvc 160.918 160.924 +0.006 +0.004%
futures 232.386 232.387 +0.001 +0.000%
game_of_life 102.229 102.229 +0.001 +0.001%
immutable 244.674 244.680 +0.006 +0.002%
inner_html 78.631 78.632 +0.001 +0.001%
js_callback 107.498 107.498 0 0.000%
keyed_list 177.176 177.175 -0.001 -0.001%
mount_point 81.767 81.768 +0.001 +0.001%
nested_list 110.766 110.767 +0.001 +0.001%
node_refs 89.222 89.226 +0.004 +0.004%
password_strength 1726.342 1726.337 -0.005 -0.000%
portals 90.788 90.791 +0.003 +0.003%
router 297.152 297.156 +0.004 +0.001%
suspense 110.996 110.997 +0.001 +0.001%
timer 86.562 86.562 +0.001 +0.001%
timer_functional 96.119 96.119 0 0.000%
todomvc 139.712 139.713 +0.001 +0.001%
two_apps 83.918 83.919 +0.001 +0.001%
web_worker_fib 133.679 133.679 0 0.000%
web_worker_prime 184.597 184.597 0 0.000%
webgl 81.185 81.186 +0.001 +0.001%

✅ None of the examples has changed their size significantly.

@Madoshakalaka Madoshakalaka marked this pull request as ready for review February 16, 2026 08:20
@Madoshakalaka Madoshakalaka merged commit 5bb2f7c into master Feb 18, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant