Skip to content

fix: set default-features = false for futures at workspace level#4009

Merged
Madoshakalaka merged 1 commit into
masterfrom
fix/futures-default-features
Feb 27, 2026
Merged

fix: set default-features = false for futures at workspace level#4009
Madoshakalaka merged 1 commit into
masterfrom
fix/futures-default-features

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka commented Feb 27, 2026

as per a cargo warning. member crate level default-features are ignored and might become a hard error in the future

github-actions[bot]
github-actions Bot previously approved these changes Feb 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Visit the preview URL for this PR (updated for commit b5a4019):

https://yew-rs-api--pr4009-fix-futures-default-71jrml5h.web.app

(expires Fri, 06 Mar 2026 06:12:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  4.005 ns      │ 4.286 ns      │ 4.009 ns      │ 4.012 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  4.012 ns      │ 4.127 ns      │ 4.016 ns      │ 4.017 ns      │ 100     │ 1000000000

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 96.692 96.690 -0.002 -0.002%
boids 165.389 165.384 -0.005 -0.003%
communication_child_to_parent 89.882 89.882 0 0.000%
communication_grandchild_with_grandparent 100.920 100.922 +0.002 +0.002%
communication_grandparent_to_grandchild 97.421 97.416 -0.005 -0.005%
communication_parent_to_child 87.301 87.299 -0.002 -0.002%
contexts 102.916 102.919 +0.003 +0.003%
counter 84.031 84.029 -0.002 -0.002%
counter_functional 85.377 85.376 -0.001 -0.001%
dyn_create_destroy_apps 87.025 87.023 -0.002 -0.002%
file_upload 96.559 96.558 -0.001 -0.001%
function_delayed_input 90.958 90.956 -0.002 -0.002%
function_memory_game 168.921 168.921 0 0.000%
function_router 326.608 326.607 -0.001 -0.000%
function_todomvc 160.896 160.899 +0.003 +0.002%
futures 232.362 232.360 -0.002 -0.001%
game_of_life 102.205 102.203 -0.002 -0.002%
immutable 244.363 244.354 -0.010 -0.004%
inner_html 78.612 78.610 -0.002 -0.002%
js_callback 107.427 107.429 +0.002 +0.002%
keyed_list 177.157 177.157 0 0.000%
mount_point 81.742 81.743 +0.001 +0.001%
nested_list 110.725 110.725 0 0.000%
node_refs 89.188 89.188 0 0.000%
password_strength 1726.272 1726.268 -0.005 -0.000%
portals 90.760 90.761 +0.001 +0.001%
router 297.183 297.188 +0.005 +0.002%
suspense 110.941 110.943 +0.002 +0.002%
timer 86.488 86.486 -0.002 -0.002%
timer_functional 96.045 96.043 -0.002 -0.002%
todomvc 139.499 139.497 -0.002 -0.001%
two_apps 83.894 83.892 -0.002 -0.002%
web_worker_fib 133.649 133.652 +0.003 +0.002%
web_worker_prime 184.604 184.594 -0.011 -0.006%
webgl 81.165 81.164 -0.001 -0.001%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.056 291.521 291.303 0.164
Hello World 10 465.630 472.078 467.579 1.926
Function Router 10 1643.594 1673.533 1665.101 8.854
Concurrent Task 10 1005.941 1007.471 1006.784 0.524
Many Providers 10 1069.753 1140.988 1109.006 24.182

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.067 291.615 291.330 0.184
Hello World 10 485.571 497.508 488.972 3.975
Function Router 10 31083.480 31721.076 31540.865 180.671
Concurrent Task 10 1005.795 1007.947 1007.061 0.681
Many Providers 10 1092.338 1124.889 1109.073 10.007

@Madoshakalaka
Copy link
Copy Markdown
Member Author

We actually see size reduction across example crates because the previous default-features setting was incorrectly ignored. huge win.

@Madoshakalaka Madoshakalaka merged commit a18f734 into master Feb 27, 2026
24 checks passed
@Madoshakalaka Madoshakalaka added the A-examples Area: The examples label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-examples Area: The examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant