Skip to content

fix: add IntoPropValue impls for Cow<'static, str> #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Madoshakalaka merged 1 commit into from
Mar 24, 2026
Merged

fix: add IntoPropValue impls for Cow<'static, str> #4051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/yew-macro/tests/html_macro/element-fail.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<implicit_clone:
`&'static [(K, V)]` implements `IntoPropValue<implicit_clone::unsync::map::IMap<K, V>>`
`&'static [T]` implements `IntoPropValue<implicit_clone::unsync::array::IArray<T>>`
`&'static str` implements `IntoPropValue<Classes>`
`&'static str` implements `IntoPropValue<Option<String>>`
`&'static str` implements `IntoPropValue<Cow<'static, str>>`
and $N others

error[E0277]: the trait bound `Option<NotToString>: IntoPropValue<Option<implicit_clone::unsync::string::IString>>` is not satisfied
Expand All @@ -487,12 +487,12 @@ error[E0277]: the trait bound `Option<NotToString>: IntoPropValue<Option<implici
= help: the following other types implement trait `IntoPropValue<T>`:
`Option<&String>` implements `IntoPropValue<Option<VNode>>`
`Option<&implicit_clone::unsync::string::IString>` implements `IntoPropValue<Option<VNode>>`
`Option<&str>` implements `IntoPropValue<Option<Cow<'_, str>>>`
Copy link
Copy Markdown
Member Author

@Madoshakalaka Madoshakalaka Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diagnostic diffs are all cosmetic

`Option<&str>` implements `IntoPropValue<Option<String>>`
`Option<&str>` implements `IntoPropValue<Option<VNode>>`
`Option<&str>` implements `IntoPropValue<Option<implicit_clone::unsync::string::IString>>`
`Option<Arc<String>>` implements `IntoPropValue<Option<VNode>>`
`Option<Arc<str>>` implements `IntoPropValue<Option<VNode>>`
`Option<Cow<'_, str>>` implements `IntoPropValue<Option<VNode>>`
and $N others

error[E0277]: the trait bound `Option<{integer}>: IntoPropValue<Option<implicit_clone::unsync::string::IString>>` is not satisfied
Expand All @@ -507,12 +507,12 @@ error[E0277]: the trait bound `Option<{integer}>: IntoPropValue<Option<implicit_
= help: the following other types implement trait `IntoPropValue<T>`:
`Option<&String>` implements `IntoPropValue<Option<VNode>>`
`Option<&implicit_clone::unsync::string::IString>` implements `IntoPropValue<Option<VNode>>`
`Option<&str>` implements `IntoPropValue<Option<Cow<'_, str>>>`
`Option<&str>` implements `IntoPropValue<Option<String>>`
`Option<&str>` implements `IntoPropValue<Option<VNode>>`
`Option<&str>` implements `IntoPropValue<Option<implicit_clone::unsync::string::IString>>`
`Option<Arc<String>>` implements `IntoPropValue<Option<VNode>>`
`Option<Arc<str>>` implements `IntoPropValue<Option<VNode>>`
`Option<Cow<'_, str>>` implements `IntoPropValue<Option<VNode>>`
and $N others

error[E0277]: the trait bound `{integer}: IntoEventCallback<MouseEvent>` is not satisfied
Expand Down Expand Up @@ -625,12 +625,12 @@ error[E0277]: the trait bound `Option<yew::NodeRef>: IntoPropValue<yew::NodeRef>
= help: the following other types implement trait `IntoPropValue<T>`:
`Option<&String>` implements `IntoPropValue<Option<VNode>>`
`Option<&implicit_clone::unsync::string::IString>` implements `IntoPropValue<Option<VNode>>`
`Option<&str>` implements `IntoPropValue<Option<Cow<'_, str>>>`
`Option<&str>` implements `IntoPropValue<Option<String>>`
`Option<&str>` implements `IntoPropValue<Option<VNode>>`
`Option<&str>` implements `IntoPropValue<Option<implicit_clone::unsync::string::IString>>`
`Option<Arc<String>>` implements `IntoPropValue<Option<VNode>>`
`Option<Arc<str>>` implements `IntoPropValue<Option<VNode>>`
`Option<Cow<'_, str>>` implements `IntoPropValue<Option<VNode>>`
and $N others

error[E0277]: the trait bound `yew::Callback<String>: IntoEventCallback<MouseEvent>` is not satisfied
Expand Down Expand Up @@ -675,7 +675,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<implicit_clone:
`&'static [(K, V)]` implements `IntoPropValue<implicit_clone::unsync::map::IMap<K, V>>`
`&'static [T]` implements `IntoPropValue<implicit_clone::unsync::array::IArray<T>>`
`&'static str` implements `IntoPropValue<Classes>`
`&'static str` implements `IntoPropValue<Option<String>>`
`&'static str` implements `IntoPropValue<Cow<'static, str>>`
and $N others

error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
Expand Down
9 changes: 9 additions & 0 deletions packages/yew/src/html/conversion/into_prop_value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@ impl_into_prop!(|value: &'static str| -> AttrValue { AttrValue::Static(value) })
impl_into_prop!(|value: String| -> AttrValue { AttrValue::Rc(Rc::from(value)) });
impl_into_prop!(|value: Rc<str>| -> AttrValue { AttrValue::Rc(value) });
impl_into_prop!(|value: Cow<'static, str>| -> AttrValue { AttrValue::from(value) });
impl_into_prop!(|value: &'static str| -> Cow<'static, str> { Cow::Borrowed(value) });
impl_into_prop!(|value: String| -> Cow<'static, str> { Cow::Owned(value) });
impl_into_prop!(|value: Rc<str>| -> Cow<'static, str> { Cow::Owned(value.to_string()) });

impl<T: ImplicitClone + 'static> IntoPropValue<IArray<T>> for &'static [T] {
fn into_prop_value(self) -> IArray<T> {
Expand Down Expand Up @@ -384,6 +387,12 @@ mod test {
let _: Option<AttrValue> = "foo".into_prop_value();
let _: Option<AttrValue> = Rc::<str>::from("foo").into_prop_value();
let _: Option<AttrValue> = Cow::Borrowed("foo").into_prop_value();
let _: Cow<'static, str> = "foo".into_prop_value();
let _: Cow<'static, str> = String::from("foo").into_prop_value();
let _: Cow<'static, str> = Rc::<str>::from("foo").into_prop_value();
let _: Option<Cow<'static, str>> = Some("foo").into_prop_value();
let _: Option<Cow<'static, str>> = Some(String::from("foo")).into_prop_value();
let _: Option<Cow<'static, str>> = Some(Rc::<str>::from("foo")).into_prop_value();
}

#[test]
Expand Down
Loading