refactor!: migrate workspace to Rust 1.85 and Edition 2024#4114
Merged
Madoshakalaka merged 13 commits intomasterfrom Apr 5, 2026
Merged
refactor!: migrate workspace to Rust 1.85 and Edition 2024#4114Madoshakalaka merged 13 commits intomasterfrom
Madoshakalaka merged 13 commits intomasterfrom
Conversation
- Set edition = "2024" in all 55 member crates - Centralize rust-version = "1.85" in [workspace.package] - Add unsafe to extern "C" blocks (Edition 2024 requirement) - Remove redundant ref/ref mut in match patterns (match ergonomics) - Escape reserved keyword gen as r#gen in examples - Fix RPIT lifetime over-capture in TagTokens::to_spanned and Registry::get_handler - Remove ref from macro-generated pattern in html_element.rs - Update rustfmt.toml and CI workflows to 1.85 - Apply Edition 2024 rustfmt style
Benchmark - coreYew MasterPull Request |
|
Visit the preview URL for this PR (updated for commit 569e4df): https://yew-rs--pr4114-rust-1-85-nstfs4w6.web.app (expires Sun, 12 Apr 2026 19:52:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size ComparisonDetails
|
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Madoshakalaka
commented
Apr 5, 2026
- Update workspace rand dependency from 0.9 to 0.10 - Rename trait import Rng to RngExt for extension methods - Replace removed SmallRng::from_os_rng() with from_rng() - Remove small_rng feature flag (always available in 0.10) - Keep rand 0.9 as rand_09 in function_router and router examples for lipsum MarkovChain API compatibility
cargo fix --edition conservatively changed all $:expr fragment
specifiers to $:expr_2021 to prevent potential ambiguity with
const {} blocks. None of these macros have conflicting rules
involving const or _ expressions, so the original expr specifier
is correct and allows matching the full Edition 2024 expression
syntax.
getrandom 0.3 (transitive from lipsum's rand 0.9) requires both the getrandom_backend cfg flag AND the wasm_js crate feature on wasm32-unknown-unknown. The cfg flag alone is insufficient. Add getrandom_03 workspace dep to propagate the feature.
# Conflicts: # packages/yew-macro/src/props/component.rs # packages/yew-macro/src/props/prop.rs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
Madoshakalaka
added a commit
that referenced
this pull request
Apr 5, 2026
Resolve conflict in blist.rs where Edition 2024 migration (#4114) changed `if let` to `match` while our branch restructured the inner keyed-reconciliation logic for render-order indices. Take master's `match ancestor` syntax with our Option<usize> barrier_idx and flipped comparison directions.
shan-shaji
pushed a commit
to shan-shaji/yew
that referenced
this pull request
Apr 19, 2026
…4114) - Set edition = "2024" in all 55 member crates - Centralize rust-version = "1.85" in [workspace.package] - Add unsafe to extern "C" blocks (Edition 2024 requirement) - Remove redundant ref/ref mut in match patterns (match ergonomics) - Escape reserved keyword gen as r#gen in examples - Fix RPIT lifetime over-capture in TagTokens::to_spanned and Registry::get_handler - Remove ref from macro-generated pattern in html_element.rs - Update rustfmt.toml and CI workflows to 1.85 - Apply Edition 2024 rustfmt style * chore: regenerate lock * chore(docs): update if-let gaurd stablization version * chore: update rand to 0.10 - Update workspace rand dependency from 0.9 to 0.10 - Rename trait import Rng to RngExt for extension methods - Replace removed SmallRng::from_os_rng() with from_rng() - Remove small_rng feature flag (always available in 0.10) - Keep rand 0.9 as rand_09 in function_router and router examples for lipsum MarkovChain API compatibility * chore: update fake to 5.x * docs: update MSRV to 1.85.0 in Next version docs * refactor: remove redundant Future imports now in Edition 2024 prelude * chore: update MSRV references from 1.84.0 to 1.85.0 in macro tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the entire workspace to Rust 1.85 / Edition 2024.
Checklist
fakemajor version was ignored but now we can update itrand0.10