Skip to content

Check for minimum required Windows version#2192

Merged
yhirose merged 1 commit into
yhirose:masterfrom
thbeu:issue_2191_cmake
Aug 2, 2025
Merged

Check for minimum required Windows version#2192
yhirose merged 1 commit into
yhirose:masterfrom
thbeu:issue_2191_cmake

Conversation

@thbeu

@thbeu thbeu commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Resolves #2191.

@yhirose

yhirose commented Jul 31, 2025

Copy link
Copy Markdown
Owner

@sum01 @jimmy-park could you please review this pull request for me? Thanks!

@sum01

sum01 commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

My first thought is to use CMAKE_SYSTEM_VERSION instead.

With CMAKE_HOST_SYSTEM_VERSION if you cross-compile it could fail if the build system version returns < 10, regardless of if you're on Windows or not.

Maybe you have other thoughts though?

@thbeu

thbeu commented Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

My first thought is to use CMAKE_SYSTEM_VERSION instead.

Sure. I changed it accordingly.

@yhirose yhirose merged commit acf28a3 into yhirose:master Aug 2, 2025
10 checks passed
@yhirose

yhirose commented Aug 2, 2025

Copy link
Copy Markdown
Owner

Thanks for making the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for minimum required Win version

3 participants