Fix ambiguous Get() examples in README after new Params overload#2486
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix documentation mismatch for httplib.h API
Add Get(path, params) convenience overload to match documented API
Jul 4, 2026
Copilot
AI
changed the title
Add Get(path, params) convenience overload to match documented API
Fix CI failures from new Get(path, params, progress) overload
Jul 4, 2026
Copilot
AI
changed the title
Fix CI failures from new Get(path, params, progress) overload
Fix ambiguous Get() examples in README after new Params overload
Jul 5, 2026
yhirose
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
Get(path, const Params&, ...)overload added ambiguity for existing call sites using bare brace-enclosed initializer lists, sinceHeadersandParamsare bothmultimap<std::string, std::string>typedefs. The README's own documented examples forGet()with headers no longer compile as a result.Changes
{{...}}initializer lists in explicithttplib::Headers{...}for all affectedGet()examples in README.md:make_range_header)Accept-Encodingvalue" examples (two call sites)Example
All updated snippets were compiled directly against
httplib.hto confirm they no longer hit the "ambiguous call to overloaded function" error.