Skip to content

fix(docs): Update Rector command in composer.json to remove unnecessary 'src' argument.#81

Merged
terabytesoftw merged 1 commit into
mainfrom
fix_mini_48
Jan 28, 2026
Merged

fix(docs): Update Rector command in composer.json to remove unnecessary 'src' argument.#81
terabytesoftw merged 1 commit into
mainfrom
fix_mini_48

Conversation

@terabytesoftw
Copy link
Copy Markdown
Member

@terabytesoftw terabytesoftw commented Jan 28, 2026

Pull Request

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Summary by CodeRabbit

  • Bug Fixes

    • Simplified Rector tool configuration in build process
  • Refactor

    • Converted test closures to arrow functions for improved code style
    • Added explicit return types to test stubs
  • Chores

    • Updated changelog for version 0.4.1

✏️ Tip: You can customize this high-level summary in your review settings.

@terabytesoftw terabytesoftw added the bug Something isn't working label Jan 28, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

The PR simplifies the Rector configuration by removing an explicit 'src' argument from the composer.json script command, updates the changelog to document this change, refactors test configuration files to use arrow functions instead of traditional anonymous functions, and adds an explicit return type annotation to a test stub method.

Changes

Cohort / File(s) Change Summary
Rector Configuration
CHANGELOG.md, composer.json
Simplified Rector command by removing the 'src' argument; updated changelog entry documenting Bug #81 fix
Test Configuration - Closure Refactoring
tests/config/definitions-closure-not-return-type.php, tests/config/phpstan-config.php, tests/config/singletons-closure-not-return-type.php
Converted traditional anonymous functions to concise arrow functions; behavior remains functionally equivalent
Test Stub Updates
tests/support/stub/BehaviorOne.php
Added explicit string return type to methodWithoutReturnType() method signature

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop and a skip through syntactic delight,
Arrow functions shine, the code looks so bright!
We've trimmed the excess from Rector's command,
Type hints now clear—oh, isn't it grand!
✨ Refactored with care, our test suite's refined!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the Rector command in composer.json to remove the 'src' argument, which is verified by the file-level summary.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (371114c) to head (ee635c0).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #81   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        71        71           
===========================================
  Files              2         2           
  Lines            126       126           
===========================================
  Hits             126       126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw merged commit a2fe54e into main Jan 28, 2026
68 checks passed
@terabytesoftw terabytesoftw deleted the fix_mini_48 branch January 28, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant