Skip to content

Commit e084e20

Browse files
committed
ci: strengthen pull-request test coverage
1 parent fde24c4 commit e084e20

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ jobs:
3333
strategy:
3434
fail-fast: false
3535
matrix:
36-
os: [ubuntu-latest, macos-latest]
36+
# Windows is a first-class target for a CLI/REPL framework, and its absence let a
37+
# CRLF-only test failure ship green (see the TrimEntries fix in Given_Completions).
38+
os: [ubuntu-latest, macos-latest, windows-latest]
3739
steps:
3840
- name: Checkout
3941
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -194,7 +196,15 @@ jobs:
194196
--coverage-output-format cobertura
195197
196198
- name: Test report
197-
if: always()
199+
# Creating a check run needs `checks: write`, but GitHub caps GITHUB_TOKEN
200+
# to read-only for `pull_request` events raised from a fork — the
201+
# workflow-level `permissions:` block cannot lift that ceiling. The action
202+
# then fails with "Resource not accessible by integration", which cascades
203+
# into skipping Pack and the package validation steps below. Fork PRs still
204+
# gate on the Test step and publish the .trx via the test-results artifact.
205+
# The `github.event_name` clause keeps the report alive on push builds,
206+
# where `github.event.pull_request` is null.
207+
if: always() && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
198208
uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5 # v1.9.1
199209
with:
200210
name: Test Results

0 commit comments

Comments
 (0)