refactor: let php-fpm start exceptions bubble up

Author: carlalexander

src/WebsiteRuntime.php

@@ -82,14 +82,7 @@ public static function createFromApplication(ApplicationInterface $application):
      */
     public function start(): void
     {
-        try {
-            $this->phpFpmProcess->start();
-        } catch (\Throwable $exception) {
-            $this->logger->exception($exception);
-            $this->client->sendInitializationError($exception);
-
-            $this->terminate(1);
-        }
+        $this->phpFpmProcess->start();
     }
 
     /**

tests/Unit/WebsiteRuntimeTest.php

@@ -189,38 +189,6 @@ public function testProcessNextEventWithPhpFpmTimeoutException(): void
         $runtime->processNextEvent();
     }
 
-    public function testStartWithException(): void
-    {
-        $client = $this->getLambdaRuntimeApiClientMock();
-        $exception = new \Exception('test exception');
-        $handler = $this->getLambdaEventHandlerInterfaceMock();
-        $logger = $this->getLoggerMock();
-        $process = $this->getPhpFpmProcessMock();
-
-        $process->expects($this->once())
-                ->method('start')
-                ->willThrowException($exception);
-
-        $logger->expects($this->once())
-               ->method('exception')
-               ->with($this->identicalTo($exception));
-
-        $client->expects($this->once())
-               ->method('sendInitializationError')
-               ->with($this->identicalTo($exception));
-
-        $runtime = $this->getMockBuilder(WebsiteRuntime::class)
-                        ->setConstructorArgs([$client, $handler, $logger, $process])
-                        ->setMethods(['terminate'])
-                        ->getMock();
-
-        $runtime->expects($this->once())
-                 ->method('terminate')
-                 ->with(1);
-
-        $runtime->start();
-    }
-
     public function testStartWithNoException(): void
     {
         $client = $this->getLambdaRuntimeApiClientMock();