chore: add some more debug logging

Author: carlalexander

src/Lambda/Handler/Http/AbstractPhpFpmRequestEventHandler.php

@@ -58,7 +58,7 @@ protected function createLambdaEventResponse(HttpRequestEvent $event): HttpRespo
         $request = FastCgiRequest::createFromInvocationEvent($event, $this->getScriptFilePath($event));
         $timeoutMs = max(1000, $event->getContext()->getRemainingTimeInMs() - 1000);
 
-        $this->logger->debug('FastCgi request sent:', [
+        $this->logger->debug('FastCGI request sent', [
             'content' => $request->getContent(),
             'parameters' => $request->getParams(),
         ]);

src/Lambda/Handler/Sqs/AbstractSqsHandler.php

@@ -63,6 +63,10 @@ public function handle(InvocationEventInterface $event): ResponseInterface
 
         $event->getRecords()->each(function (SqsRecord $record) use ($event, &$failedRecords): void {
             try {
+                $this->logger->debug(sprintf('Processing SQS message [%s]', $record->getMessageId()), [
+                    'record' => $record->toArray(),
+                ]);
+
                 $this->processRecord($event->getContext(), $record);
             } catch (\Throwable $exception) {
                 $this->logger->error(sprintf('Processing SQS message [%s] failed: %s', $record->getMessageId(), $exception->getMessage()), [

src/Lambda/Handler/WarmUpEventHandler.php

@@ -19,6 +19,7 @@
 use Ymir\Runtime\Lambda\InvocationEvent\WarmUpEvent;
 use Ymir\Runtime\Lambda\Response\Http\HttpResponse;
 use Ymir\Runtime\Lambda\Response\ResponseInterface;
+use Ymir\Runtime\Logger;
 
 /**
  * Lambda invocation event handler for warming up Lambda functions.
@@ -32,12 +33,20 @@ class WarmUpEventHandler implements LambdaEventHandlerInterface
      */
     private $lambdaClient;
 
+    /**
+     * The logger that sends logs to CloudWatch.
+     *
+     * @var Logger
+     */
+    private $logger;
+
     /**
      * Constructor.
      */
-    public function __construct(LambdaClient $lambdaClient)
+    public function __construct(LambdaClient $lambdaClient, Logger $logger)
     {
         $this->lambdaClient = $lambdaClient;
+        $this->logger = $logger;
     }
 
     /**
@@ -69,6 +78,8 @@ public function handle(InvocationEventInterface $event): ResponseInterface
             throw new InvalidConfigurationException('"AWS_LAMBDA_FUNCTION_NAME" environment variable is\'t set');
         }
 
+        $this->logger->debug(sprintf('Warming up %s additional functions', $concurrency));
+
         // The first Lambda function invoked will be the one running this code. So, if we want the number of concurrent
         // Lambda functions to match, we need to keep the concurrency number the same and not subtract one from it.
         for ($i = 0; $i < $concurrency; ++$i) {

src/Runtime.php

@@ -58,7 +58,7 @@ public static function create(): RuntimeInterface
 
             $handlers = [
                 new PingLambdaEventHandler(),
-                new WarmUpEventHandler(new LambdaClient(['region' => $region], null, null, $logger)),
+                new WarmUpEventHandler(new LambdaClient(['region' => $region], null, null, $logger), $logger),
             ];
 
             switch ($functionType) {

tests/Unit/Lambda/Handler/Sqs/AbstractSqsHandlerTest.php

@@ -62,6 +62,9 @@ public function testHandleCollectsFailures(): void
         ]);
 
         $logger = $this->getLoggerMock();
+        $logger->expects($this->exactly(3))
+               ->method('debug')
+               ->with($this->stringContains('Processing SQS message [id'));
         $logger->expects($this->once())
                ->method('error');
 

tests/Unit/Lambda/Handler/WarmUpEventHandlerTest.php

@@ -20,23 +20,25 @@
 use Ymir\Runtime\Tests\Mock\FunctionMockTrait;
 use Ymir\Runtime\Tests\Mock\InvocationEventInterfaceMockTrait;
 use Ymir\Runtime\Tests\Mock\LambdaClientMockTrait;
+use Ymir\Runtime\Tests\Mock\LoggerMockTrait;
 use Ymir\Runtime\Tests\Mock\WarmUpEventMockTrait;
 
 class WarmUpEventHandlerTest extends TestCase
 {
     use FunctionMockTrait;
     use InvocationEventInterfaceMockTrait;
     use LambdaClientMockTrait;
+    use LoggerMockTrait;
     use WarmUpEventMockTrait;
 
     public function testCanHandleWarmUpEventType(): void
     {
-        $this->assertTrue((new WarmUpEventHandler($this->getLambdaClientMock()))->canHandle($this->getWarmUpEventMock()));
+        $this->assertTrue((new WarmUpEventHandler($this->getLambdaClientMock(), $this->getLoggerMock()))->canHandle($this->getWarmUpEventMock()));
     }
 
     public function testCanHandleWrongEventType(): void
     {
-        $this->assertFalse((new WarmUpEventHandler($this->getLambdaClientMock()))->canHandle($this->getInvocationEventInterfaceMock()));
+        $this->assertFalse((new WarmUpEventHandler($this->getLambdaClientMock(), $this->getLoggerMock()))->canHandle($this->getInvocationEventInterfaceMock()));
     }
 
     public function testHandleDoesntInvokeAdditionalFunctionsWhenConcurrencyIsOne(): void
@@ -51,7 +53,7 @@ public function testHandleDoesntInvokeAdditionalFunctionsWhenConcurrencyIsOne():
         $lambdaClient->expects($this->never())
                      ->method('invoke');
 
-        $reponse = (new WarmUpEventHandler($lambdaClient))->handle($event);
+        $reponse = (new WarmUpEventHandler($lambdaClient, $this->getLoggerMock()))->handle($event);
 
         $this->assertInstanceOf(HttpResponse::class, $reponse);
         $this->assertSame([
@@ -69,11 +71,16 @@ public function testHandleInvokesAdditionalFunctions(): void
         $event = $this->getWarmUpEventMock();
         $getenv = $this->getFunctionMock($this->getNamespace(WarmUpEventHandler::class), 'getenv');
         $lambdaClient = $this->getLambdaClientMock();
+        $logger = $this->getLoggerMock();
 
         $event->expects($this->any())
               ->method('getConcurrency')
               ->willReturn(3);
 
+        $logger->expects($this->once())
+               ->method('debug')
+               ->with($this->identicalTo('Warming up 3 additional functions'));
+
         $getenv->expects($this->once())
                ->with($this->identicalTo('AWS_LAMBDA_FUNCTION_NAME'))
                ->willReturn('function-name');
@@ -85,10 +92,10 @@ public function testHandleInvokesAdditionalFunctions(): void
                          'Qualifier' => 'deployed',
                          'InvocationType' => 'Event',
                          'LogType' => 'None',
-                         'Payload' => '{"ping": true}',
-                     ]);
+                          'Payload' => '{"ping": true}',
+                      ]);
 
-        $reponse = (new WarmUpEventHandler($lambdaClient))->handle($event);
+        $reponse = (new WarmUpEventHandler($lambdaClient, $logger))->handle($event);
 
         $this->assertInstanceOf(HttpResponse::class, $reponse);
         $this->assertSame([
@@ -112,14 +119,14 @@ public function testHandleWithNoEnvironmentVariable(): void
               ->method('getConcurrency')
               ->willReturn(3);
 
-        (new WarmUpEventHandler($this->getLambdaClientMock()))->handle($event);
+        (new WarmUpEventHandler($this->getLambdaClientMock(), $this->getLoggerMock()))->handle($event);
     }
 
     public function testHandleWithWrongEventType(): void
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('WarmUpEventHandler can only handle WarmUpEvent objects');
 
-        (new WarmUpEventHandler($this->getLambdaClientMock()))->handle($this->getInvocationEventInterfaceMock());
+        (new WarmUpEventHandler($this->getLambdaClientMock(), $this->getLoggerMock()))->handle($this->getInvocationEventInterfaceMock());
     }
 }