fix: kill the lambda container if we get a ReadFailedException exception

Author: carlalexander

src/Lambda/Response/BadGatewayHttpResponse.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of Ymir PHP Runtime.
+ *
+ * (c) Carl Alexander <support@ymirapp.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Ymir\Runtime\Lambda\Response;
+
+/**
+ * A Lambda response for a 502 HTTP response.
+ */
+class BadGatewayHttpResponse extends AbstractErrorHttpResponse
+{
+    /**
+     * Constructor.
+     */
+    public function __construct(string $message = 'Bad Gateway', string $templatesDirectory = '')
+    {
+        parent::__construct($message, 502, $templatesDirectory);
+    }
+}

src/Runtime.php

@@ -17,6 +17,7 @@
 use AsyncAws\Ssm\Input\GetParametersByPathRequest;
 use AsyncAws\Ssm\SsmClient;
 use AsyncAws\Ssm\ValueObject\Parameter;
+use hollodotme\FastCGI\Exceptions\ReadFailedException;
 use Tightenco\Collect\Support\Arr;
 use Ymir\Runtime\FastCgi\PhpFpmProcess;
 use Ymir\Runtime\Lambda\Handler\BedrockLambdaEventHandler;
@@ -28,6 +29,7 @@
 use Ymir\Runtime\Lambda\Handler\RadicleLambdaEventHandler;
 use Ymir\Runtime\Lambda\Handler\WarmUpEventHandler;
 use Ymir\Runtime\Lambda\Handler\WordPressLambdaEventHandler;
+use Ymir\Runtime\Lambda\Response\BadGatewayHttpResponse;
 use Ymir\Runtime\Lambda\RuntimeApiClient;
 
 /**
@@ -175,6 +177,13 @@ public function processNextEvent(): void
             $this->client->sendResponse($event, $this->handler->handle($event));
 
             ++$this->invocations;
+        } catch (ReadFailedException $exception) {
+            $this->logger->exception($exception);
+
+            $this->client->sendResponse($event, new BadGatewayHttpResponse('The process handling the request crashed unexpectedly'));
+
+            $this->logger->info('Killing Lambda container. PHP-FPM process has crashed.');
+            $this->terminate(1);
         } catch (\Throwable $exception) {
             $this->logger->exception($exception);
             $this->client->sendEventError($event, $exception);

tests/Unit/RuntimeTest.php

@@ -13,7 +13,9 @@
 
 namespace Ymir\Runtime\Tests\Unit;
 
+use hollodotme\FastCGI\Exceptions\ReadFailedException;
 use PHPUnit\Framework\TestCase;
+use Ymir\Runtime\Lambda\Response\BadGatewayHttpResponse;
 use Ymir\Runtime\Runtime;
 use Ymir\Runtime\Tests\Mock\InvocationEventInterfaceMockTrait;
 use Ymir\Runtime\Tests\Mock\LambdaEventHandlerInterfaceMockTrait;
@@ -77,6 +79,50 @@ public function testProcessNextEvent()
         $runtime->processNextEvent();
     }
 
+    public function testProcessNextEventWithReadFailedException()
+    {
+        $client = $this->getLambdaRuntimeApiClientMock();
+        $event = $this->getInvocationEventInterfaceMock();
+        $handler = $this->getLambdaEventHandlerInterfaceMock();
+        $logger = $this->getLoggerMock();
+        $process = $this->getPhpFpmProcessMock();
+
+        $runtime = $this->getMockBuilder(Runtime::class)
+                        ->setConstructorArgs([$client, $handler, $logger, $process])
+                        ->setMethods(['terminate'])
+                        ->getMock();
+
+        $client->expects($this->once())
+               ->method('getNextEvent')
+               ->willReturn($event);
+
+        $handler->expects($this->once())
+                ->method('canHandle')
+                ->with($this->identicalTo($event))
+                ->willReturn(true);
+        $handler->expects($this->once())
+                ->method('handle')
+                ->with($this->identicalTo($event))
+                ->willThrowException(new ReadFailedException());
+
+        $logger->expects($this->once())
+               ->method('exception')
+               ->with($this->isInstanceOf(ReadFailedException::class));
+        $logger->expects($this->once())
+               ->method('info')
+               ->with('Killing Lambda container. PHP-FPM process has crashed.');
+
+        $client->expects($this->once())
+               ->method('sendResponse')
+               ->with($this->identicalTo($event), $this->isInstanceOf(BadGatewayHttpResponse::class));
+
+        $runtime->expects($this->once())
+                ->method('terminate')
+                ->with(1);
+
+        $runtime->processNextEvent();
+    }
+
     public function testStartWithNoException()
     {
         $client = $this->getLambdaRuntimeApiClientMock();