[35]更新が必要なパッケージ情報をIssueに起票するPIpelineの作成#409
Merged
Merged
Conversation
yumemi-team-review-requester
Bot
requested review from
a team,
blendthink and
den0206
and removed request for
a team
|
Ready for review 🚀 |
|
Visit the preview URL for this PR (updated for commit cf44bf0): https://flutter-mobile-project-template-catalog--pr409-feature-qzhw3zgf.web.app (expires Thu, 22 May 2025 04:58:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
9 tasks
7 tasks
den0206
suggested changes
May 14, 2025
den0206
reviewed
May 14, 2025
Contributor
Author
|
@den0206 |
Contributor
|
@r0227n
今のままだと、更新を行なった際に変更を加えない限り、無制限にIssueが登録されると考えており。。 |
Contributor
Author
|
@den0206 対応完了後、再度レビューよろしくお願いします🙇 {
"comments": [
{
"id": "IC_kwDOK5kQ_s6qygaB",
"author": {
"login": "github-actions"
},
"authorAssociation": "NONE",
"body": "## Update package\n| package | current | resolvable |\n| :--- | :--- | :--- |\n | build_runner | 2.4.14 | 2.4.15 | \n| dio | 5.7.0 | 5.8.0+1 | \n| flutter_gen_runner | 5.8.0 | 5.10.0 | \n| flutter_hooks | 0.20.5 | 0.21.2 | \n| flutter_launcher_icons | 0.14.2 | 0.14.3 | \n| flutter_markdown | 0.7.5 | 0.7.7+1 | \n| go_router | 14.6.3 | 15.1.2 | \n| go_router_builder | 2.7.3 | 2.9.0 | \n| package_info_plus | 8.1.2 | 8.3.0 | \n| shared_preferences | 2.3.5 | 2.5.3 | \n| widgetbook | 3.10.2 | 3.13.1 | \n| widgetbook_annotation | 3.2.0 | 3.4.0 | \n| widgetbook_generator | 3.9.1 | 3.12.0 | \n| yumemi_lints | 3.1.0 | 4.0.0 |\n",
"createdAt": "2025-05-09T06:57:42Z",
"includesCreatedEdit": false,
"isMinimized": false,
"minimizedReason": "",
"reactionGroups": [],
"url": "https://github.com/yumemi-inc/flutter-mobile-project-template/issues/408#issuecomment-2865366657",
"viewerDidAuthor": false
},
{
"id": "IC_kwDOK5kQ_s6qytLG",
"author": {
"login": "github-actions"
},
"authorAssociation": "NONE",
"body": "## Update package\n| package | current | resolvable |\n| :--- | :--- | :--- |\n | build_runner | 2.4.14 | 2.4.15 | \n| dio | 5.7.0 | 5.8.0+1 | \n| flutter_gen_runner | 5.8.0 | 5.10.0 | \n| flutter_hooks | 0.20.5 | 0.21.2 | \n| flutter_launcher_icons | 0.14.2 | 0.14.3 | \n| flutter_markdown | 0.7.5 | 0.7.7+1 | \n| go_router | 14.6.3 | 15.1.2 | \n| go_router_builder | 2.7.3 | 2.9.0 | \n| package_info_plus | 8.1.2 | 8.3.0 | \n| shared_preferences | 2.3.5 | 2.5.3 | \n| widgetbook | 3.10.2 | 3.13.1 | \n| widgetbook_annotation | 3.2.0 | 3.4.0 | \n| widgetbook_generator | 3.9.1 | 3.12.0 | \n| yumemi_lints | 3.1.0 | 4.0.0 |\n",
"createdAt": "2025-05-09T07:16:51Z",
"includesCreatedEdit": false,
"isMinimized": false,
"minimizedReason": "",
"reactionGroups": [],
"url": "https://github.com/yumemi-inc/flutter-mobile-project-template/issues/408#issuecomment-2865418950",
"viewerDidAuthor": false
}
] |
auto-merge was automatically disabled
May 14, 2025 06:15
Pull request was converted to draft
Contributor
Author
|
Ready for review 🚀 |
Contributor
Author
|
@den0206 動作確認の方法https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/15034752820 https://github.com/yumemi-inc/flutter-mobile-project-template/labels/package_update のラベルを追加したり、削除・コメントの削除などで動作確認可能となります。 動作確認内容 |
den0206
reviewed
May 15, 2025
Comment on lines
+82
to
+85
| if [[ "$package_comment" == "$latest_comment" ]]; then | ||
| echo "The latest comment is the same as the current comment" | ||
| exit 0 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
dart pub outdatedを実行し、パッケージの依存関係が更新が必要になった時にIssueにコメントするPipelineを作成。Issueについて
package_updatedというlabelが存在するIssueにコメント形式でパッケージの更新情報をコメントするpackage_updatedのlabelがついたIssueが2個以上存在する場合、失敗するようになっているレビュー観点
レビューレベル
レビュー優先度
画像 / 動画
N/A
確認したこと
正常実行完了
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/14923295269
#408
「package_update」が2個以上作成されたIssueの場合、強制終了する
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/14923515726/job/41923209042
#408
#407
2回目以降の実行でコメントが重複するかどうか
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/14923590555
#408 (comment)
動作確認手順
a6f19d2 の状態に戻し、pushするとActionが実行されます。
備考
コメントの内容が重複する場合、新規コメントは作成しない 方が良い場合、実装可能か再度調査します。重複した場合、処理をスキップするようにしました。
concurrencyは今回、
scheduleで実行するため不要と判断しました。