Improve: pubspec.yaml の dependencies の最適化#447
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 065e76d): https://flutter-mobile-project-template-catalog--pr447-feature-hd5ytbgz.web.app (expires Thu, 22 May 2025 07:02:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
den0206
force-pushed
the
feature/fix_dependency
branch
from
5ba4761 to
c57244b
Compare
Compare pubspec.yaml and pubspec.lock. Packages with different version notations
|
blendthink
reviewed
May 15, 2025
blendthink
left a comment
blendthink
left a comment
Contributor
There was a problem hiding this comment.
@den0206
１点だけコメントさせていただきましたのでご確認お願いします 🙏
| visibility_detector: ^0.4.0+2 | ||
| dev_dependencies: | ||
| build_runner: ^2.4.14 | ||
| build_verify: ^3.1.0 |
Contributor
There was a problem hiding this comment.
build_verify は使用されていないので apps/app からも削除お願いします 🙏
den0206
force-pushed
the
feature/fix_dependency
branch
from
0338dbe to
d65cc6f
Compare
github-actions
Bot
added
@apps/app
pubspec.lock has been changed
|
den0206
commented
May 15, 2025
| shared_preferences_foundation: fcdcbc04712aee1108ac7fda236f363274528f78 | ||
| package_info_plus: af8e2ca6888548050f16fa2f1938db7b5a5df499 | ||
| shared_preferences_foundation: 9e1978ff2562383bd5676f64ec4e9aa8fa06a6f7 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
最新でapp/appsをiOSビルドを行うと更新される為、追加しました。
恐らく、私の下記PR時の漏れになります。
#402
den0206
commented
May 15, 2025
| if (pkgYaml[name] is! String) { | ||
| return false; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@r0227n
恐らくtools/diff_yaml.dartを実装されたと考えるためメンションします。
今回の対応で,dev_dependenciesにflutter_testが追加されCIでエラーが出るようになった為例外処理を修正しました。
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/15034628768/job/42254019777
もしより良い改善案がありましたらご教授ください。
上記のままで良い場合は,無視で大丈夫です！
den0206
force-pushed
the
feature/fix_dependency
branch
from
d65cc6f to
a51f64e
Compare
yumemi-team-review-requester
Bot
requested review from
a team,
fa0311 and
masa-futa
and removed request for
a team
|
Ready for review 🚀 |
pubspec.lock has been changed
|
pubspec.lock has been changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
apps/app、packages/*は以下に記載のあるパッケージを ルートのpubspec.yamlに記載しました。pubspec.lockの値が異なるパッケージのバージョン更新レビュー観点
apps/app、packages/*配下のpubspec.yaml記載されており、ルートのpubspec.yamlに記載されていないパッケージが存在しないかレビューレベル
レビュー優先度
画像 / 動画
確認したこと
apps/app、packages/*配下のpubspec.yamlの複数確認melos bsの実行動作確認手順
melos bsを実行する備考