chore: CSpell の設定強化#457
Merged
Merged
Conversation
yumemi-team-review-requester
Bot
requested review from
a team,
blendthink and
r0227n
and removed request for
a team
|
Ready for review 🚀 |
fa0311
commented
May 15, 2025
Comment on lines
+10
to
+15
| "overrides": [ | ||
| { | ||
| "filename": "**/*.{md,yaml,yml,dart}", | ||
| "dictionaries": ["dart", "flutter"] | ||
| } | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
dart, flutter辞書はdart言語扱いのファイル(*.dart)にしか適用されないので上書きします
|
Visit the preview URL for this PR (updated for commit d750d99): https://flutter-mobile-project-template-catalog--pr457-chore-g-nzlc7xkv.web.app (expires Thu, 22 May 2025 23:55:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
fa0311
commented
May 15, 2025
| { | ||
| "name": "flutter-term", | ||
| "description": "Flutter related terms", | ||
| "path": "./.cspell/flutter-term.txt", |
Contributor
Author
There was a problem hiding this comment.
dart 辞書にはpubdevの上位100件のパッケージ名が含まれており、今回使用されているパッケージは全て含まれていたため空になりました
ですが、念の為残しております
blendthink
approved these changes
May 15, 2025
blendthink
left a comment
blendthink
left a comment
Contributor
There was a problem hiding this comment.
LGTM です！
勉強になりました！ご対応ありがとうございます！
自分のプルリクエストはクローズしておきますね〜
Comment on lines
+17
to
+18
| // https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/lib/src/dart/error/todo_codes.dart | ||
| "(TODO|FIXME|HACK|UNDONE)\\([^)]*\\)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
close: #384
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
確認したこと
$ bun run cspell CSpell: Files checked: 319, Issues found: 0 in 0 files.動作確認手順
bun run cspell備考
bunxは ローカルのバージョンを参照しないのでbun runを使用してください