Improve: mise コマンドの追加#504
Merged
Merged
Conversation
yumemi-team-review-requester
Bot
requested review from
a team,
macneko-ayu and
masa-futa
and removed request for
a team
|
Ready for review 🚀 |
den0206
commented
May 27, 2025
Comment on lines
+18
to
+22
| [tasks.cspell] | ||
| description = "Run cspell to check spelling." | ||
| run = [ | ||
| 'bun run cspell lint', | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
bun run cspell lint 自体を忘れそうなので追加しました
(mise.toml に書いてあれば忘れずに使用ができる)
不必要であれば削除します
blendthink
approved these changes
May 27, 2025
blendthink
left a comment
blendthink
left a comment
Contributor
There was a problem hiding this comment.
とてもいいと思いました 🫶
LGTM です！
ご対応ありがとうございます！
| "husky": "^9.1.7" | ||
| }, | ||
| "scripts": { | ||
| "clean": "git clean -xdf node_modules", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
mise run <コマンド名>で実行可能なコマンドを追加しましたcleancspell拡張機能を入れておくとボタンでも実行できます
レビュー観点
mise run cleanが実行できるか？mise run cspellが実行できるか？レビューレベル
レビュー優先度
画像 / 動画
確認したこと
動作確認手順
mise run cleanの実行mise run cspellの実行備考