パッケージの更新#537
Merged
Merged
Conversation
|
Ready for review 🚀 |
pubspec.lock has been changed
Compare pubspec.yaml and pubspec.lock. Packages with different version notations
|
|
|
pubspec.lock has been changed
|
Contributor
Author
> melos run gen
ERROR: [FlutterGen] Specified build.yaml as input but the file does not contain valid options, ignoring...と出力されるため、 |
pubspec.lock has been changed
|
pubspec.lock has been changed
|
|
|
|
Ready for review 🚀 |
pubspec.lock has been changed
|
Contributor
Author
pacckages/cores/designsystem/pubspec.yamlflutter_gen_runner:
output: lib/src/gen/assets
assets:
outputs:
package_parameter_enabled: true5ba6e0cで追加した [cores_designsystem]: [FlutterGen] v5.10.0 Loading ...
[cores_designsystem]: [FlutterGen] Reading options from pubspec.yaml
ERROR: ERROR: ERROR: [cores_designsystem]: [FlutterGen] Specified build.yaml as input but the file does not exists.そのため、 |
blendthink
reviewed
Jun 4, 2025
Contributor
blendthink
left a comment
There was a problem hiding this comment.
@r0227n
1点コメントさせていただきましたのでご確認お願いします 🙏
…memi-inc/flutter-mobile-project-template into feature/update-package-202506
|
|
Contributor
Author
|
@blendthink |
pubspec.lock has been changed
|
blendthink
approved these changes
Jun 4, 2025
Contributor
blendthink
left a comment
There was a problem hiding this comment.
ご対応ありがとうございます!LGTMです!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
close: Update package #531
close: [Bug]: apps/catalog のtestを修正する #535
パッケージの更新
flutter_genを使用しているパッケージは明示的に
build.yamlに設定を追記freezed v2 -> v3へのmigrate対応
自動生成系パッケージの変更をステージング
更新したパッケージ一覧
レビュー観点
flutter analyzeで正常終了するか?apps/appがビルド可能か?レビューレベル
レビュー優先度
画像 / 動画
N /A
確認したこと
flutter analyzeで正常終了することapps/appでflutter pub run build_runner build -dが正常終了し、ビルドも問題ないことを確認packagesディレクトリでflutter test .を実行し、テストが全て成功することを確認melos run golden_testとmelos run golden_test:ciを実行し、テストが成功melos run test&melos run test:dart一部だけ失敗(SDKの部分で失敗しているため、PRの影響ではないと思われる)melos run test:flutter正常終了動作確認手順
flutter analyzeを実行するapps/appディレクトリでflutter pub run build_runner build -dを実行後、ビルドするmelos run test:flutterを実行する備考
apps/appでビルド時に警告が発生するが、本問題はmainでも発生するためPRの変更による問題ではない。#536
としてIssueを起票し、別件で対応する。