refactor: domain_logicパッケージのFlutter依存を除去し、ThemeModeをThemeSettingとして純粋なDartパッケージ化#575
Merged
Conversation
github-actions
Bot
added
@apps/app
yumemi-team-review-requester
Bot
requested review from
a team,
fa0311 and
hidekitux
and removed request for
a team
|
Ready for review 🚀 |
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
blendthink
requested review from
morikann and
trm11tkr
and removed request for
fa0311 and
hidekitux
morikann
reviewed
Aug 29, 2025
Contributor
morikann
left a comment
morikann
left a comment
There was a problem hiding this comment.
ご対応ありがとうございます！一点だけコメントさせていただきました🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
domain_logicパッケージのFlutter依存を除去し、純粋なDartパッケージとして再構築しましたレビュー観点
domain_logicパッケージからFlutter依存が適切に除去されているかレビューレベル
レビュー優先度
画像 / 動画
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-28.at.14.31.27.mp4
確認したこと
domain_logicパッケージからFlutter依存が除去されていること動作確認手順
packages/domain_logicでdart pub getが正常に実行できることを確認する備考
domain_logicパッケージを純粋なDartパッケージとして再構築しました