Skip to content

chore: パッケージの更新(ルーター系)#584

Merged
blendthink merged 5 commits into
mainfrom
chore/GH-551-router-package-update
Sep 4, 2025
Merged

chore: パッケージの更新(ルーター系)#584
blendthink merged 5 commits into
mainfrom
chore/GH-551-router-package-update

Conversation

@morikann
Copy link
Copy Markdown
Contributor

@morikann morikann commented Sep 1, 2025

概要

レビュー観点

  • ビルドが成功するか
  • CI が通っているか
  • 遷移処理が問題なく動作するか

レビューレベル

  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

画像 / 動画

見た目に関する変更がないため省略します。

確認したこと

  • iOS のビルドが通ること
  • Android のビルドが通ること
  • 遷移処理が問題なく動作すること

動作確認手順

  • iOS/Android でビルドを行う

備考

@github-actions github-actions Bot added @apps/app Application development @packages/debug packages debug package labels Sep 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 1, 2025

pubspec.lock has been changed

Change Diff
packages.go_router.description.sha256 {previous: 0b1e06223bee260dee31a171fb1153e306907563a0b0225e8c1733211911429a, current: eb059dfe59f08546e9787f895bd01652076f996bcbf485a8609ef990419ad227}
packages.go_router.version {previous: 15.1.2, current: 16.2.1}
packages.go_router_builder.description.sha256 {previous: 7f6f4bfb97cadc3d25378a0237fe4ddd98b54d6094b5a5c158b775a2cc30843e, current: e436f0c69e717bd215639fbe27381b7e6605a255852b45cb244e28f01ab2e93a}
packages.go_router_builder.version {previous: 2.9.0, current: 3.0.0}


@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 1, 2025

⚠️ Rebase or force-push detected in this push
以下のコミットが非線形な履歴となっており、rebase または強制 push の可能性があります:

  • d6dadd8 (chore: widgetbook term を辞書に追加)
  • f2dab61 (chore: deviceFrameAddon を viewportAddon を置き換え)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 1, 2025

pubspec.lock has been changed

Change Diff
packages.go_router.description.sha256 {previous: 0b1e06223bee260dee31a171fb1153e306907563a0b0225e8c1733211911429a, current: eb059dfe59f08546e9787f895bd01652076f996bcbf485a8609ef990419ad227}
packages.go_router.version {previous: 15.1.2, current: 16.2.1}
packages.go_router_builder.description.sha256 {previous: 7f6f4bfb97cadc3d25378a0237fe4ddd98b54d6094b5a5c158b775a2cc30843e, current: e436f0c69e717bd215639fbe27381b7e6605a255852b45cb244e28f01ab2e93a}
packages.go_router_builder.version {previous: 2.9.0, current: 3.0.0}


@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 1, 2025

pubspec.lock has been changed

Change Diff
packages.go_router.description.sha256 {previous: 0b1e06223bee260dee31a171fb1153e306907563a0b0225e8c1733211911429a, current: eb059dfe59f08546e9787f895bd01652076f996bcbf485a8609ef990419ad227}
packages.go_router.version {previous: 15.1.2, current: 16.2.1}
packages.go_router_builder.description.sha256 {previous: 7f6f4bfb97cadc3d25378a0237fe4ddd98b54d6094b5a5c158b775a2cc30843e, current: e436f0c69e717bd215639fbe27381b7e6605a255852b45cb244e28f01ab2e93a}
packages.go_router_builder.version {previous: 2.9.0, current: 3.0.0}


],
)
class DebugPageRoute extends GoRouteData {
class DebugPageRoute extends GoRouteData with _$DebugPageRoute {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memo-badge
migration guide に則って対応しています。

@morikann morikann marked this pull request as ready for review September 3, 2025 10:13
@yumemi-team-review-requester yumemi-team-review-requester Bot requested review from a team, fa0311 and r0227n and removed request for a team September 3, 2025 10:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 3, 2025

Ready for review 🚀

@morikann morikann requested review from blendthink and trm11tkr and removed request for fa0311 and r0227n September 3, 2025 10:13
Base automatically changed from chore/GH-551-code-gen-package-update to main September 4, 2025 02:59
Copy link
Copy Markdown
Contributor

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です!
ご対応ありがとうございます!

えいやでマージしちゃいます!

@blendthink blendthink added this pull request to the merge queue Sep 4, 2025
Merged via the queue into main with commit c8d4cd3 Sep 4, 2025
19 checks passed
@blendthink blendthink deleted the chore/GH-551-router-package-update branch September 4, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@apps/app Application development @packages/debug packages debug package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants