feat(design_ui): assetsをresディレクトリ配下に移動#591
Merged
Merged
Conversation
- packages/design_uiのassets/ディレクトリをres/assets/に移動 - pubspec.yamlのアセットパスをres/assets/に更新 - 生成されたassets.gen.dartを新しいパス構造に合わせて更新 - プロジェクトのリソース管理規約に合わせてres/配下でリソースを整理
- CommonAssets.yumemiLogo を CommonAssets.res.assets.yumemiLogo に変更 - 行の長さ制限に合わせてコードを整形
yumemi-team-review-requester
Bot
requested review from
a team,
karas1910 and
trm11tkr
and removed request for
a team
|
Ready for review 🚀 |
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
packages/design_ui の assets を res 配下に移動しました。
プロジェクトのリソース管理規約に従って、すべてのリソースを res 配下で整理する対応です。
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
確認したこと
動作確認手順
melos bsを実行してワークスペースを更新dart analyzeで静的解析を実行melos run gen:buildでコード生成を実行備考
Assets.res.assets.yumemiLogoの形式でアクセス可能です