[Improve]: packages/samples 配下のアーキテクチャ検討#595
Merged
Merged
Conversation
- Add data layer with Dio configuration and repository providers - Add domain layer with GitHub repository models and exceptions - Add UI layer with list and detail pages - Add pagination support using utils_pagination - Update pubspec.yaml with required dependencies - Add build.yaml for code generation - Remove dependency on packages/samples/github_repository This consolidates the GitHub repository sample functionality into a single self-contained sample app for better learning experience.
- Remove packages/samples/github_repository directory - Update pubspec.yaml to remove reference to deleted package - Update melos configuration to reflect package removal - All functionality has been integrated into samples/github_app This completes the consolidation of GitHub repository sample functionality into a single self-contained sample app.
- Remove route.dart file and move navigation logic directly into UI pages - Remove unnecessary provider for navigation - Simplify main.dart by removing complex provider setup - Move navigation method directly into GitHubRepositoryListPage - Remove generated files that are no longer needed This makes the sample app more straightforward and easier to understand for learning purposes.
github-actions
Bot
added
@packages/samples/github_repository
@samples/github_app
yumemi-team-review-requester
Bot
requested review from
a team,
BlueEventHorizon and
morikann
and removed request for
a team
|
Ready for review 🚀 |
blendthink
requested review from
trm11tkr
and removed request for
BlueEventHorizon
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
trm11tkr
reviewed
Sep 9, 2025
Contributor
trm11tkr
left a comment
trm11tkr
left a comment
There was a problem hiding this comment.
一点質問させていただきましたのでご確認お願いします！🙏
Base automatically changed from
improve/GH-542/modeling-md-implementation
to
main
September 9, 2025 08:07
|
|
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
blendthink
commented
Sep 9, 2025
Contributor
Author
blendthink
left a comment
blendthink
left a comment
There was a problem hiding this comment.
@trm11tkr
いくつか修正させていただきましたのでご確認お願いいたします 🙏
- Move ScrollNotifier to appropriate location for UI state management - Update import path in github_repository_list_page.dart - Regenerate build files with melos run gen:build
blendthink
temporarily deployed
to
github-pages
GitHub Actions
Inactive
- Sort import directives alphabetically to follow Dart conventions - Resolve dart analyze warning about directive ordering
trm11tkr
approved these changes
Sep 10, 2025
Contributor
trm11tkr
left a comment
trm11tkr
left a comment
There was a problem hiding this comment.
LGTM です！
ご対応いただきありがとうございます！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Issue 472「packages/samples 配下のアーキテクチャ検討」に対応し、
packages/samples/github_repositoryの機能をsamples/github_appに統合しました。学習用サンプルアプリとして、Dioの使い方とページング処理の実装方法を一つのアプリ内で確認できるようにシンプル化しました。
レビュー観点
packages/samples/github_repositoryの削除が適切かsamples/github_appへの機能統合が適切かレビューレベル
レビュー優先度
画像 / 動画
2025-09-09.11.04.06.mov
確認したこと
samples/github_appが正常にビルドできること動作確認手順
cd samples/github_appflutter pub getを実行dart run build_runner buildを実行flutter analyzeで静的解析を実行備考
packages/samples/github_repositoryを完全に削除し、機能をsamples/github_appに統合