Publisher instances sort by folder path and product name and fix shif…#1802
Open
rischpierre wants to merge 2 commits into
Open
Publisher instances sort by folder path and product name and fix shif…#1802rischpierre wants to merge 2 commits into
rischpierre wants to merge 2 commits into
Conversation
iLLiCiTiT
reviewed
Apr 22, 2026
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
reviewed
Apr 22, 2026
| for instance in instances: | ||
| for instance in sorted( | ||
| instances_by_group[group_name], | ||
| key=lambda i: (i.get_folder_path() or "", i.product_name)) |
Member
There was a problem hiding this comment.
Just realized this is InstanceItem not CreatedInstance.
Suggested change
| key=lambda i: (i.get_folder_path() or "", i.product_name)) | |
| key=lambda i: (i.folder_path or "", i.product_name)) |
Member
There was a problem hiding this comment.
Still same question, why this was moved here? It makes more sense to sort them in _update_instance_widgets if possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Hello, I noticed a bug on the Publisher regarding the order of instances and the mutlitple selection in the case of multishot workflow.
I did not saw any issue regarding this, so I created this MR directly
here is the bug ( you can see the selection is messed up)
and after this fix
I also sorted the instances by shot and then product name so it is easier for the artists.
Testing notes: