Skip to content

Implementation of custom frame range collector#1818

Draft
moonyuet wants to merge 14 commits into
developfrom
enhancement/YN-0726--Custom-Frame-Range-Support-for-Local-Rendering
Draft

Implementation of custom frame range collector#1818
moonyuet wants to merge 14 commits into
developfrom
enhancement/YN-0726--Custom-Frame-Range-Support-for-Local-Rendering

Conversation

@moonyuet

@moonyuet moonyuet commented May 8, 2026

Copy link
Copy Markdown
Member

Changelog Description

This PR is to implement the custom frame range collector with the custom frame range migrated from deadline addon.

Additional info

Tested with ynput/ayon-deadline#252

Testing notes:

  1. Create Render
  2. Test with both local and farm rendering.
  3. Test with or without custom frame range

@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition labels May 8, 2026
@moonyuet moonyuet self-assigned this May 8, 2026
@moonyuet moonyuet added the sponsored This is directly sponsored by a client or community member label May 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements a new Pyblish collector in ayon-core to expose and collect an artist-configurable “custom frame range” for render submissions (migrated from the Deadline addon behavior), storing the selected frame expression into instance data for downstream submission logic.

Changes:

  • Added CollectCustomFrameRange instance plugin to provide publish attributes (use_custom_frames, frames) and collect them into instance.data.
  • Added create-context value-change callback to refresh the attribute definitions when relevant values change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread client/ayon_core/plugins/publish/collect_custom_frame_range.py Outdated
Comment thread client/ayon_core/plugins/publish/collect_custom_frame_range.py
Comment thread client/ayon_core/plugins/publish/collect_custom_frame_range.py Outdated
moonyuet and others added 2 commits May 11, 2026 14:31
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ynbot ynbot moved this to Review In Progress in PR reviewing May 11, 2026
@BigRoy BigRoy requested a review from iLLiCiTiT May 11, 2026 07:28
Comment thread client/ayon_core/plugins/publish/collect_custom_frame_range.py Outdated
Comment on lines +15 to +25
families = [
"render", "render.local", "render.farm", "render.frames_farm",
"prerender", "prerender.farm", "prerender.frames_farm",
"renderlayer", "imagesequence", "image",
"vrayscene", "maxrender",
"arnold_rop", "mantra_rop",
"karma_rop", "vray_rop", "redshift_rop",
"renderFarm", "usdrender", "publish.hou",
"remote_publish_on_farm",
"deadline"
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, this is painful. We'll need to define a better way to when this plug-in should be relevant.

@iLLiCiTiT let's discuss when we can find some time.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you're right. This might the breakpoint for me. We will have to tackle the "families" thing.

@LiborBatek LiborBatek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me together with ayon-3dsmax and ayon-deadline with related branches...

Image

@github-project-automation github-project-automation Bot moved this from Review In Progress to Merge Requested in PR reviewing Jun 3, 2026
@ynbot ynbot moved this from Merge Requested to Review In Progress in PR reviewing Jun 9, 2026
@iLLiCiTiT

Copy link
Copy Markdown
Member

Currently shows the attribute at places where it should not be visible. Has to be resolved first (connected to #1818 (comment) )

@moonyuet moonyuet marked this pull request as draft June 9, 2026 13:45
@antirotor

Copy link
Copy Markdown
Member

So is there any follow-up issue somewhere? I guess it is bigger topic with families and all, but it shouldn't hold up resolution of this? If it works, lets merge it, but create the issue to fix the families?

@iLLiCiTiT

iLLiCiTiT commented Jun 22, 2026

Copy link
Copy Markdown
Member

If it works, lets merge it, but create the issue to fix the families?

It works where it is needed, and it breaks places where it should not be used. So yes, it does resolve the issue, but creates multiple other issues.

@BigRoy

BigRoy commented Jul 2, 2026

Copy link
Copy Markdown
Member

So yes, it does resolve the issue, but creates multiple other issues.

Let's describe the new issues it creates - track them by priority and resolve the ones we absolutely must and then get to making tickets for those that can be fixed later please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

Status: Review In Progress

Development

Successfully merging this pull request may close these issues.

7 participants