Launcher and Workfiles tool use AYON UI Qt components#1879
Launcher and Workfiles tool use AYON UI Qt components#1879mahesh-ynput wants to merge 60 commits into
Conversation
…and Workfiles tools
…r both Launcher and Workfiles tools
…ration - Save dialog: Extensions combobox now uses plain=True mode rendering native Qt dropdown arrow instead of AYON status/pill style - Save dialog: Cancel button changed to Surface (grey) variant; Ok button stays Filled (blue) — only primary action is coloured - Save dialog: Artist note field gains focus on open so blinking cursor makes it visually obvious it is editable - My tasks checkbox: replaced NiceCheckbox+QLabel with AYCheckBox to match the Published checkbox style consistently - Reduce line count bloat: consolidate ayon_ui_qt per-module imports to single-line imports across all migrated files; remove now- redundant fixed_width=False and setSizePolicy boilerplate that is handled by ayon-ui-qt component defaults
AYComboBox now draws its own dropdown arrow — workaround no longer needed
- make Open/Browse/Save As buttons grey - restore focus to subversion on save dialog()
- Side panel Details/Artist Note use framed form layout matching browser - Section headers sized to match Version Info/Representations headers - Replace artist note QPlainTextEdit with AYTextEdit - Table headers: larger font and height to match browser table headers - Outer window margin 8px → 16px to match browser outer margins
…ltering - Replace TreeView/DeselectableTreeView with AYTreeView in FoldersWidget, TasksWidget, WorkfilesView - Replace PlaceholderLineEdit with AYLineEdit in FoldersFiltersWidget - Fix workfile selection filtering actions: guard column == 0 in _on_selection_changed - Outer window margin and spacing to 16px to match with browser redesign
…Margins which matches original look - Bring back set_deselectable ad Jakub mentioned this was used by other tools - Removed setMinimumWidth for AYCheckBox and fixed root cause within AYCheckBox in ayon-ui-qt - Hiding missed artist_note upon Published Checked - Replaced GoToCurrentButton with AYButton for consistency
…qt-luncher # Conflicts: # client/ayon_core/tools/launcher/ui/workfiles_page.py # client/ayon_core/tools/utils/tasks_widget.py
…nents. - icon_definitions. - Reverted QHeaderView default from style.css. - hnaged ayon_ui_qt components imports style.
mahesh-ynput
changed the title
There was a problem hiding this comment.
- Workfiles tool should not allow multiselect workfiles
- Workfiles tool artist note text size is much smaller than the rest - let's make it same font size.
- Workfiles tool - is date modified column smaller font size? and is it on purpose?
- Workfiles tool - can we make the details not enforce a minimum width for the content in it. currently if you have it quite small, but select a workfile then suddenly the UI makes it wider - I want to avoid that minimum width to make the UI move around when selecting workfiles. It shouldn't jump around.
- Workfiles tool - when there's no workfiles in work area, then the Date Modified column renders with a different background color? It should not.
- Workfiles tool details, can we reduce the height padding/margins between each entry so that top details needs less vertical space.
- Workfile tool details sidebar, can we make it so that the Artist Note takes up the available space if UI gets more vertical and the details at the top only ever take as much vertical space as needed
- Workfile tool details sidebar, the "- Comment" field is useless if Published checkbox is disabled so let's remove that entry.
- When switching to "Published" checkbox, can we make the Artist Note area especially turn into the "Comment" area and have the publish comment just displayed there (without a Save Note button of course).
- Can we make the folders, tasks and workfiles have slightly reduced vertical margins/padding in the views. I just want to make it so you can squeeze in more info on screen - so you can see similar amount of data as before the PR. May need some input from @philippe-ynput
It also has different highlight/hover colors it seems?
- The font looks awful in Admin > Console (script editor) on Windows?
…style parameters to delegate
…tyle/fonts and reading directly from ayon-core/client/ayon_core/ui/resources - added ui_resources_path to __init__.py
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…der style or more decent look
the duplicated functionality set_custom_delegate() wrapper from combo_box.py.
BigRoy
added
ui
type: enhancement
There was a problem hiding this comment.
Tested with the launcher and workfile tools too. They all work as expected(Nice job btw).
I do have several comments/suggestions.
General
- The text style is a little bit difficult to read when comparing to the one in the develop branch. (I prefer the current text style).
The workfile tool, I have two suggestions in regards.
is it intended to highlight the created date of workfile? It is perhaps a better idea not to highlight the date(But if there is any reason behind, just ignore this comment).
When opening the workfile tool from Ayon menu, opening workfile and relaunch workfile tool from ayon menu again, the Task order has been switched for some reason.
https://github.com/user-attachments/assets/912b3ce9-5f74-47ba-8961-39802a70d429
That's a bug - it should not highlight it, it should paint the same light-blue 'active' color, not white.
Ah man - the font just doesn't work out nicely. Anyway, the font size should be Once we've done that I think I'll have a review session with Milan after annecy about the font on desktop - I'm personally rather unhappy with this font on desktop because it just doesn't render nice on Windows. But the UIs (when it does render nicely) look much more like the web UI because of the matching font and otherwise with the old font things kept looking a bit off compared to web UI.
That'd be a bug. It should currently adhere to the sorting as defined in core settings. It's either alphebatical or (task-type-anatomy-sort-order, and secondary alphabetical). See also setting
|
Apply the same fix in this PR I'd say. There may be a small merge conflict, but because it's the same code it should auto-resolve and if not, it's easy to resolve the conflict. |
…which replaced the PrettyTimeDelegate for both files_widget_published.py and files_widget_workarea.py - Fixed font size to 10.5pt for launcher
Noted, 18278bf |
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@BigRoy , I'm seeing this behavior in latest develop branch also, So is that okay to we can fix this issue in this PR or we can have separate PR for this? |
In this case - I assume the issue isn't on the UI side but on the controller. In that case, can you make a fix for it to |
|
The text becomes more readable now |
Yes - Mahesh stated same issue exists in |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
What is the status of this PR? |
|
6 participants
Changelog Description
Replaced native Qt widgets with ayon-ui-qt equivalents in Launcher and Workfiles tools alone.
Additional info
Testing notes:
Test Launcher and Workfiles see replaced new UI components which matches close to web UI components