Last workfile information#1892
Draft
iLLiCiTiT wants to merge 3 commits into
Draft
Conversation
iLLiCiTiT
added
the
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add last workfile helpers to find information about last workfile.
Additional info
There is not an issue for this but during application launch we do store last workfile as just a path to the launch context, but we do not store the information if the file actually exist, what is the rootless path and what version it is -> all of that is calculated when last workfile is prepared for launch hook, we just don't have it available.
The goal is that the information is added to launch hooks and is used for launch logic. With that we should STOP filling
last_workfile_pathwithworkfile_pathin case it is filled. Ifworkfile_pathis filled, it should be used andlast_workfile_pathshould always have information about last workfile.I did start to work on this during this PR but decided it does not fit the "quick" solution needed for that. This is a long run solution as it requires changes across multiple addons.
Testing notes:
...Needs to be filled...