Skip to content

Commit f6d31de

Browse files
committed
add activity id back
1 parent e5779a2 commit f6d31de

2 files changed

Lines changed: 16 additions & 20 deletions

File tree

ayon_api/_api.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,9 +1205,9 @@ def upload_project_file(
12051205
content_type: str | None = None,
12061206
filename: str | None = None,
12071207
file_id: str | None = None,
1208+
activity_id: str | None = None,
12081209
chunk_size: int | None = None,
12091210
progress: TransferProgress | None = None,
1210-
**kwargs,
12111211
) -> requests.Response:
12121212
"""Upload project file from a filepath.
12131213
@@ -1222,6 +1222,7 @@ def upload_project_file(
12221222
filename (str | None): Server filename, filename from filepath
12231223
is used if not passed.
12241224
file_id (str | None): File id.
1225+
activity_id (str | None): To which activity is file related.
12251226
chunk_size (int | None): Size of chunks that are received
12261227
in single loop.
12271228
progress (TransferProgress | None): Object that gives ability
@@ -1238,9 +1239,9 @@ def upload_project_file(
12381239
content_type=content_type,
12391240
filename=filename,
12401241
file_id=file_id,
1242+
activity_id=activity_id,
12411243
chunk_size=chunk_size,
12421244
progress=progress,
1243-
**kwargs,
12441245
)
12451246

12461247

@@ -1251,9 +1252,9 @@ def upload_project_file_from_stream(
12511252
*,
12521253
content_type: str | None = None,
12531254
file_id: str | None = None,
1255+
activity_id: str | None = None,
12541256
chunk_size: int | None = None,
12551257
progress: TransferProgress | None = None,
1256-
**kwargs,
12571258
) -> requests.Response:
12581259
"""Upload project file from a filepath.
12591260
@@ -1267,6 +1268,7 @@ def upload_project_file_from_stream(
12671268
filename (str): Name of file on server.
12681269
content_type (str | None): MIME type of file.
12691270
file_id (str | None): File id.
1271+
activity_id (str | None): To which activity is file related.
12701272
chunk_size (int | None): Size of chunks that are received
12711273
in single loop.
12721274
progress (TransferProgress | None): Object that gives ability
@@ -1283,9 +1285,9 @@ def upload_project_file_from_stream(
12831285
filename=filename,
12841286
content_type=content_type,
12851287
file_id=file_id,
1288+
activity_id=activity_id,
12861289
chunk_size=chunk_size,
12871290
progress=progress,
1288-
**kwargs,
12891291
)
12901292

12911293

ayon_api/server_api.py

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1809,10 +1809,9 @@ def upload_project_file(
18091809
content_type: str | None = None,
18101810
filename: str | None = None,
18111811
file_id: str | None = None,
1812+
activity_id: str | None = None,
18121813
chunk_size: int | None = None,
18131814
progress: TransferProgress | None = None,
1814-
# TODO remove when 'activity_id' is handled
1815-
**kwargs
18161815
) -> requests.Response:
18171816
"""Upload project file from a filepath.
18181817
@@ -1827,6 +1826,7 @@ def upload_project_file(
18271826
filename (str | None): Server filename, filename from filepath
18281827
is used if not passed.
18291828
file_id (str | None): File id.
1829+
activity_id (str | None): To which activity is file related.
18301830
chunk_size (int | None): Size of chunks that are received
18311831
in single loop.
18321832
progress (TransferProgress | None): Object that gives ability
@@ -1844,16 +1844,13 @@ def upload_project_file(
18441844
if not content_type:
18451845
content_type = "application/octet-stream"
18461846

1847-
if "activity_id" in kwargs:
1848-
self.log.warning(
1849-
"DEV WARNING: Uploading file does not support to specify"
1850-
" 'activity_id'."
1851-
)
1852-
18531847
headers = {}
18541848
if file_id:
18551849
headers["x-file-id"] = file_id
18561850

1851+
if activity_id:
1852+
headers["x-activity-id"] = activity_id
1853+
18571854
return self.upload_file(
18581855
f"api/projects/{project_name}/files",
18591856
filepath,
@@ -1873,10 +1870,9 @@ def upload_project_file_from_stream(
18731870
*,
18741871
content_type: str | None = None,
18751872
file_id: str | None = None,
1873+
activity_id: str | None = None,
18761874
chunk_size: int | None = None,
18771875
progress: TransferProgress | None = None,
1878-
# TODO remove when 'activity_id' handling is removed
1879-
**kwargs
18801876
) -> requests.Response:
18811877
"""Upload project file from a filepath.
18821878
@@ -1890,6 +1886,7 @@ def upload_project_file_from_stream(
18901886
filename (str): Name of file on server.
18911887
content_type (str | None): MIME type of file.
18921888
file_id (str | None): File id.
1889+
activity_id (str | None): To which activity is file related.
18931890
chunk_size (int | None): Size of chunks that are received
18941891
in single loop.
18951892
progress (TransferProgress | None): Object that gives ability
@@ -1905,16 +1902,13 @@ def upload_project_file_from_stream(
19051902
if not content_type:
19061903
content_type = "application/octet-stream"
19071904

1908-
if "activity_id" in kwargs:
1909-
self.log.warning(
1910-
"DEV WARNING: Uploading file does not support to specify"
1911-
" 'activity_id'."
1912-
)
1913-
19141905
headers = {}
19151906
if file_id:
19161907
headers["x-file-id"] = file_id
19171908

1909+
if activity_id:
1910+
headers["x-activity-id"] = activity_id
1911+
19181912
return self.upload_file_from_stream(
19191913
f"api/projects/{project_name}/files",
19201914
stream,

0 commit comments

Comments
 (0)