Skip to content

fix: copy original diagnostic message#221

Merged
kevinramharak merged 1 commit into
yoavbls:mainfrom
MFA-G:fix/copy-original-diagnostic-message
Jul 9, 2026
Merged

fix: copy original diagnostic message#221
kevinramharak merged 1 commit into
yoavbls:mainfrom
MFA-G:fix/copy-original-diagnostic-message

Conversation

@MFA-G

@MFA-G MFA-G commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass the original TypeScript diagnostic message to the copy-error action in hover and sidebar output
  • Keep symbol-link enriched messages only for rendered/translation content, so clipboard text no longer includes the rendered HTML link markup

Fixes #220

Validation

  • npm run build --workspace @pretty-ts-errors/utils
  • npm run build --workspace @pretty-ts-errors/formatter
  • npm run build --workspace @pretty-ts-errors/vscode-formatter
  • npm run lint --workspace @pretty-ts-errors/vscode-formatter
  • npm run test --workspace @pretty-ts-errors/vscode-formatter

Note: full npm run test starts the VS Code extension integration test and cannot complete in this headless cron environment because Electron reports Missing X server or $DISPLAY.

@kevinramharak kevinramharak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware the fix was this simple, looks great.

@kevinramharak kevinramharak merged commit 646efd1 into yoavbls:main Jul 9, 2026
1 check passed
@kevinramharak

Copy link
Copy Markdown
Collaborator

@MFA-G Thank you for your contribution, i'm not sure when @yoavbls will be able to create a new release. This isn't critical and since there have been no reports, I think this feature is not used very often, so I don't think it has any urgency.

@yoavbls

yoavbls commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Thank you!
I don't see an urgency either but I definitely can publish a new release if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Copy error to clipboard" button includes button html in output

3 participants