Skip to content

Commit bc55b37

Browse files
Added missing derives to dialect marker structs (apache#2191)
1 parent cb21477 commit bc55b37

File tree

14 files changed

+28
-14
lines changed

14 files changed

+28
-14
lines changed

src/dialect/ansi.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
use crate::dialect::Dialect;
1919

2020
/// A [`Dialect`] for [ANSI SQL](https://en.wikipedia.org/wiki/SQL:2011).
21-
#[derive(Debug, Default)]
21+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
22+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
2223
pub struct AnsiDialect {}
2324

2425
impl Dialect for AnsiDialect {

src/dialect/bigquery.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ const RESERVED_FOR_COLUMN_ALIAS: &[Keyword] = &[
4242
];
4343

4444
/// A [`Dialect`] for [Google Bigquery](https://cloud.google.com/bigquery/)
45-
#[derive(Debug, Default)]
45+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
46+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
4647
pub struct BigQueryDialect;
4748

4849
impl Dialect for BigQueryDialect {

src/dialect/clickhouse.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
use crate::dialect::Dialect;
1919

2020
/// A [`Dialect`] for [ClickHouse](https://clickhouse.com/).
21-
#[derive(Debug, Default)]
21+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
22+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
2223
pub struct ClickHouseDialect {}
2324

2425
impl Dialect for ClickHouseDialect {

src/dialect/databricks.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ use crate::dialect::Dialect;
2020
/// A [`Dialect`] for [Databricks SQL](https://www.databricks.com/)
2121
///
2222
/// See <https://docs.databricks.com/en/sql/language-manual/index.html>.
23-
#[derive(Debug, Default)]
23+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
24+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
2425
pub struct DatabricksDialect;
2526

2627
impl Dialect for DatabricksDialect {

src/dialect/duckdb.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
use crate::dialect::Dialect;
1919

2020
/// A [`Dialect`] for [DuckDB](https://duckdb.org/)
21-
#[derive(Debug, Default)]
21+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
22+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
2223
pub struct DuckDbDialect;
2324

2425
// In most cases the redshift dialect is identical to [`PostgresSqlDialect`].

src/dialect/generic.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ use crate::dialect::Dialect;
1919

2020
/// A permissive, general purpose [`Dialect`], which parses a wide variety of SQL
2121
/// statements, from many different dialects.
22-
#[derive(Debug, Default)]
22+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
23+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
2324
pub struct GenericDialect;
2425

2526
impl Dialect for GenericDialect {

src/dialect/hive.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
use crate::dialect::Dialect;
1919

2020
/// A [`Dialect`] for [Hive](https://hive.apache.org/).
21-
#[derive(Debug, Default)]
21+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
22+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
2223
pub struct HiveDialect {}
2324

2425
impl Dialect for HiveDialect {

src/dialect/mssql.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ use crate::tokenizer::Token;
2828
use alloc::{vec, vec::Vec};
2929

3030
/// A [`Dialect`] for [Microsoft SQL Server](https://www.microsoft.com/en-us/sql-server/)
31-
#[derive(Debug, Default)]
31+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
32+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
3233
pub struct MsSqlDialect {}
3334

3435
impl Dialect for MsSqlDialect {

src/dialect/mysql.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ const RESERVED_FOR_TABLE_ALIAS_MYSQL: &[Keyword] = &[
3535
];
3636

3737
/// A [`Dialect`] for [MySQL](https://www.mysql.com/)
38-
#[derive(Debug, Default)]
38+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
39+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
3940
pub struct MySqlDialect {}
4041

4142
impl Dialect for MySqlDialect {

src/dialect/oracle.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ use super::{keywords::Keyword, Dialect, Precedence};
2727
const RESERVED_KEYWORDS_FOR_SELECT_ITEM_OPERATOR: [Keyword; 1] = [Keyword::CONNECT_BY_ROOT];
2828

2929
/// A [`Dialect`] for [Oracle Databases](https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlrf/index.html)
30-
#[derive(Debug, Default)]
30+
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
31+
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
3132
pub struct OracleDialect;
3233

3334
impl Dialect for OracleDialect {

0 commit comments

Comments
 (0)