Skip to content

Commit 9834966

Browse files
authored
Fixed dependencies range for doctrine & symfony (#40)
1 parent 2ec299a commit 9834966

7 files changed

Lines changed: 38 additions & 22 deletions

File tree

.travis.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,18 @@ language: php
22

33
php:
44
- 7.0
5-
- 7.1
6-
- 7.2
5+
- 7.4
76

87
env:
98
- SYMFONY_VERSION="2.7.*"
109
- SYMFONY_VERSION="2.8.*"
1110
- SYMFONY_VERSION="3.4.*"
12-
- SYMFONY_VERSION="4.0.*"
11+
- SYMFONY_VERSION="4.4.*"
1312

1413
matrix:
1514
exclude:
1615
- php: 7.0
17-
env: SYMFONY_VERSION="4.0.*" # Symfony >= 4.0 PHP requirement is ^7.1.3
16+
env: SYMFONY_VERSION="4.4.*" # Symfony >= 4.0 PHP requirement is ^7.1.3
1817

1918
sudo: false
2019

@@ -24,7 +23,7 @@ cache:
2423

2524
before_install:
2625
- composer selfupdate
27-
- if [ "$SYMFONY_VERSION" = "3.4.*" ] || [ "$SYMFONY_VERSION" = "4.0.*" ]; then rm -f phpunit.xml; cp phpunit.sf4.xml.dist phpunit.xml; fi
26+
- if [ "$SYMFONY_VERSION" = "3.4.*" ] || [ "$SYMFONY_VERSION" = "4.4.*" ]; then rm -f phpunit.xml; cp phpunit.sf4.xml.dist phpunit.xml; fi
2827
- if [ "$SYMFONY_VERSION" != "" ]; then composer require "symfony/framework-bundle:${SYMFONY_VERSION}" --no-update; fi;
2928

3029
install: COMPOSER_MEMORY_LIMIT=-1 travis_retry composer install --prefer-dist --no-interaction

DependencyInjection/Configuration.php

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
66
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
77
use Symfony\Component\Config\Definition\ConfigurationInterface;
8+
use Symfony\Component\HttpKernel\Kernel;
89

910
/**
1011
* @author Yann Eugoné <eugone.yann@gmail.com>
@@ -16,8 +17,13 @@ class Configuration implements ConfigurationInterface
1617
*/
1718
public function getConfigTreeBuilder()
1819
{
19-
$builder = new TreeBuilder();
20-
$root = $builder->root('yokai_security_token');
20+
if (version_compare(Kernel::VERSION, '4.2') >= 0) {
21+
$builder = new TreeBuilder('yokai_security_token');
22+
$root = $builder->getRootNode();
23+
} else {
24+
$builder = new TreeBuilder();
25+
$root = $builder->root('yokai_security_token');
26+
}
2127

2228
$root->addDefaultsIfNotSet();
2329
$root
@@ -35,8 +41,13 @@ public function getConfigTreeBuilder()
3541
*/
3642
private function getTokensNode()
3743
{
38-
$builder = new TreeBuilder();
39-
$node = $builder->root('tokens');
44+
if (version_compare(Kernel::VERSION, '4.2') >= 0) {
45+
$builder = new TreeBuilder('tokens');
46+
$node = $builder->getRootNode();
47+
} else {
48+
$builder = new TreeBuilder();
49+
$node = $builder->root('tokens');
50+
}
4051

4152
$node
4253
->useAttributeAsKey('purpose')
@@ -69,8 +80,13 @@ private function getTokensNode()
6980
*/
7081
private function getServicesNode()
7182
{
72-
$builder = new TreeBuilder();
73-
$node = $builder->root('services');
83+
if (version_compare(Kernel::VERSION, '4.2') >= 0) {
84+
$builder = new TreeBuilder('services');
85+
$node = $builder->getRootNode();
86+
} else {
87+
$builder = new TreeBuilder();
88+
$node = $builder->root('services');
89+
}
7490

7591
$node->addDefaultsIfNotSet();
7692
$node

Manager/DoctrineUserManager.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
namespace Yokai\SecurityTokenBundle\Manager;
44

5-
use Doctrine\Common\Persistence\ManagerRegistry;
6-
use Doctrine\Common\Persistence\ObjectManager;
5+
use Doctrine\Persistence\ManagerRegistry;
6+
use Doctrine\Persistence\ObjectManager;
77
use Doctrine\Common\Util\ClassUtils;
88

99
/**

Resources/doc/3-usage.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ The following example is about allowing unauthenticated user to recover a lost p
99
namespace AppBundle\Controller;
1010

1111
use App\Entity\User;
12-
use Doctrine\Common\Persistence\ObjectManager;
13-
use Doctrine\Common\Persistence\ObjectRepository;
14-
use Doctrine\Common\Persistence\ManagerRegistry;
12+
use Doctrine\Persistence\ObjectManager;
13+
use Doctrine\Persistence\ObjectRepository;
14+
use Doctrine\Persistence\ManagerRegistry;
1515
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
1616
use Symfony\Component\HttpFoundation\Request;
1717
use Symfony\Component\HttpFoundation\Response;

Tests/DependencyInjection/DependencyInjectionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
namespace Yokai\SecurityTokenBundle\Tests\DependencyInjection;
44

5-
use Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain;
6-
use Doctrine\Common\Persistence\ManagerRegistry;
5+
use Doctrine\Persistence\Mapping\Driver\MappingDriverChain;
6+
use Doctrine\Persistence\ManagerRegistry;
77
use Doctrine\ORM\Configuration;
88
use Doctrine\ORM\EntityManager;
99
use Prophecy\Prophecy\ProphecySubjectInterface;

Tests/Manager/DoctrineUserManagerTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
namespace Yokai\SecurityTokenBundle\Tests\Manager;
44

5-
use Doctrine\Common\Persistence\ManagerRegistry;
6-
use Doctrine\Common\Persistence\Mapping\ClassMetadata;
7-
use Doctrine\Common\Persistence\ObjectManager;
5+
use Doctrine\Persistence\ManagerRegistry;
6+
use Doctrine\Persistence\Mapping\ClassMetadata;
7+
use Doctrine\Persistence\ObjectManager;
88
use Doctrine\ORM\EntityManagerInterface;
99
use Prophecy\Prophecy\ObjectProphecy;
1010
use Yokai\SecurityTokenBundle\Manager\DoctrineUserManager;

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
"require": {
1212
"php": ">=7.0",
1313
"ext-openssl": "*",
14-
"symfony/framework-bundle": "~2.7|~3.0|~4.0",
14+
"symfony/framework-bundle": "^2.7|^3.0|^4.0",
1515
"doctrine/orm": "^2.5",
16+
"doctrine/persistence": "^2.0",
1617
"doctrine/doctrine-bundle": ">=1.6",
1718
"yokai/dependency-injection": "~1.0"
1819
},

0 commit comments

Comments
 (0)