Fuseji lookup (eg. マ○ドナ○ド) #2437
Open
noatdk wants to merge 11 commits into
Open
Conversation
…to filter by key before materializing
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a09aec3e7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for looking up fuseji (伏せ字) (per #2436).
Screenshots
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||越えられない壁||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||越えられない壁||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Chrome, macOS, only PixivLight installed
How it works
Triggers are single-character wildcards. Since IndexedDB only does prefix scans, the lookup is anchored on the unmasked text:
skip_scan_flow_rect.mp4
Settings
Two new rows under Advanced translation settings:
translation.enableFusejiLookup(toggle, defaultfalse)translation.fusejiTriggers(text, default◯○〇●)Trigger characters act as one-character wildcards during lookup; the default set covers the common circle variants used as masks.
Limitations
マ◯◯ド) are slower and noisy: every word that fits the all-masked span counts as a partial match, so each extra adjacent trigger multiplies the number of results (and the time to build them).◯んでるfor死んでる), the visible tail (んでる) is not a dictionary-form headword and the anchor we look up is the stripped tail, so it cant resolve to死ぬ. Supporting it would require deinflecting the visible tail and reconstructing the pattern (◯んでる → ◯ぬ/◯む) before lookup.