Set file extension for aac audio media type#5
Closed
Aquafina-water-bottle wants to merge 1 commit into
Closed
Conversation
djahandarie
approved these changes
Mar 5, 2023
Collaborator
djahandarie
left a comment
djahandarie
left a comment
There was a problem hiding this comment.
LGTM. We should potentially also look for other filetypes that would be reasonable to include. Or maybe there is a library that does this task which would be better to use.
Approved, but yeah let's hold on merging for a bit until we have the project fully setup.
Author
|
Closed in favor of #8 |
Kuuuube
pushed a commit
to Kuuuube/yomitan
that referenced
this pull request
Feb 3, 2024
Bumps [fast-json-patch](https://github.com/Starcounter-Jack/JSON-Patch) to 3.1.1 and updates ancestor dependency [web-ext](https://github.com/mozilla/web-ext). These dependencies need to be updated together. Updates `fast-json-patch` from 2.2.1 to 3.1.1 - [Release notes](https://github.com/Starcounter-Jack/JSON-Patch/releases) - [Commits](Starcounter-Jack/JSON-Patch@v2.2.1...3.1.1) Updates `web-ext` from 7.3.0 to 7.5.0 - [Release notes](https://github.com/mozilla/web-ext/releases) - [Commits](mozilla/web-ext@7.3.0...7.5.0) --- updated-dependencies: - dependency-name: fast-json-patch dependency-type: indirect - dependency-name: web-ext dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone of FooSoft#2302
Note: It might be best to delay merging this PR in until this project becomes more organized.