ignore info plists in synced folders

Author: yonaskolb

Sources/XcodeGenKit/PBXProjGenerator.swift

@@ -686,8 +686,14 @@ public class PBXProjGenerator {
         let infoPlistFiles: [Config: String] = getInfoPlists(for: target)
         let sourceFileBuildPhaseOverrideSequence: [(Path, BuildPhaseSpec)] = Set(infoPlistFiles.values).map({ (project.basePath + $0, .none) })
         let sourceFileBuildPhaseOverrides = Dictionary(uniqueKeysWithValues: sourceFileBuildPhaseOverrideSequence)
-        let sourceFiles = try sourceGenerator.getAllSourceFiles(targetType: target.type, sources: target.sources, buildPhases: sourceFileBuildPhaseOverrides)
-            .sorted { $0.path.lastComponent < $1.path.lastComponent }
+        let targetObject = targetObjects[target.name]!
+        let sourceFiles = try sourceGenerator.getAllSourceFiles(
+            target: targetObject,
+            targetType: target.type,
+            sources: target.sources,
+            buildPhases: sourceFileBuildPhaseOverrides
+        )
+        .sorted { $0.path.lastComponent < $1.path.lastComponent }
 
         var anyDependencyRequiresObjCLinking = false
 
@@ -1439,8 +1445,6 @@ public class PBXProjGenerator {
             defaultConfigurationName: defaultConfigurationName
         ))
 
-        let targetObject = targetObjects[target.name]!
-
         let targetFileReference = targetFileReferences[target.name]
 
         targetObject.name = target.name

Sources/XcodeGenKit/SourceGenerator.swift

@@ -86,13 +86,13 @@ class SourceGenerator {
     ///   - targetType: The type of target that the source files should belong to.
     ///   - sources: The array of sources defined as part of the targets spec.
     ///   - buildPhases: A dictionary containing any build phases that should be applied to source files at specific paths in the event that the associated `TargetSource` didn't already define a `buildPhase`. Values from this dictionary are used in cases where the project generator knows more about a file than the spec/filesystem does (i.e if the file should be treated as the targets Info.plist and so on).
-    func getAllSourceFiles(targetType: PBXProductType, sources: [TargetSource], buildPhases: [Path : BuildPhaseSpec]) throws -> [SourceFile] {
-        try sources.flatMap { try getSourceFiles(targetType: targetType, targetSource: $0, buildPhases: buildPhases) }
+    func getAllSourceFiles(target: PBXTarget, targetType: PBXProductType, sources: [TargetSource], buildPhases: [Path : BuildPhaseSpec]) throws -> [SourceFile] {
+        try sources.flatMap { try getSourceFiles(target: target, targetType: targetType, targetSource: $0, buildPhases: buildPhases) }
     }
 
     // get groups without build files. Use for Project.fileGroups
     func getFileGroups(path: String) throws {
-        _ = try getSourceFiles(targetType: .none, targetSource: TargetSource(path: path), buildPhases: [:])
+        _ = try getSourceFiles(target: nil, targetType: .none, targetSource: TargetSource(path: path), buildPhases: [:])
     }
 
     func getFileType(path: Path) -> FileType? {
@@ -601,7 +601,7 @@ class SourceGenerator {
     }
 
     /// creates source files
-    private func getSourceFiles(targetType: PBXProductType, targetSource: TargetSource, buildPhases: [Path: BuildPhaseSpec]) throws -> [SourceFile] {
+    private func getSourceFiles(target: PBXTarget?, targetType: PBXProductType, targetSource: TargetSource, buildPhases: [Path: BuildPhaseSpec]) throws -> [SourceFile] {
 
         // generate excluded paths
         let path = project.basePath + targetSource.path
@@ -690,13 +690,23 @@ class SourceGenerator {
         case .syncedFolder:
 
             let relativePath = (try? path.relativePath(from: project.basePath)) ?? path
-
+			
+            var exceptions: [PBXFileSystemSynchronizedExceptionSet] = []
+            let ignoredFiles = Array(buildPhases.filter { $0.value == .none }.keys)
+            if let target, !ignoredFiles.isEmpty {
+                let memberShipExceptions = ignoredFiles
+                    .map { (try? $0.relativePath(from: project.basePath)) ?? $0 }
+                    .map(\.string)
+                let exception = PBXFileSystemSynchronizedBuildFileExceptionSet(target: target, membershipExceptions: memberShipExceptions, publicHeaders: nil, privateHeaders: nil, additionalCompilerFlagsByRelativePath: nil, attributesByRelativePath: nil)
+                addObject(exception)
+                exceptions.append(exception)
+            }
             let syncedRootGroup = PBXFileSystemSynchronizedRootGroup(
                 sourceTree: .group,
                 path: relativePath.string,
                 name: targetSource.name,
                 explicitFileTypes: [:],
-                exceptions: [],
+                exceptions: exceptions,
                 explicitFolders: []
             )
             addObject(syncedRootGroup)

Tests/Fixtures/TestProject/Project.xcodeproj/project.pbxproj

@@ -830,9 +830,22 @@
 		FED40A89162E446494DDE7C7 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist; path = Info.plist; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
+/* Begin PBXFileSystemSynchronizedBuildFileExceptionSet section */
+		"TEMP_067E2B5F-0F9F-4B71-A34B-DB4FEB8A01AC" /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
+			isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
+			membershipExceptions = (
+				App_iOS/Info.plist,
+			);
+			target = 0867B0DACEF28C11442DE8F7 /* App_iOS */;
+		};
+/* End PBXFileSystemSynchronizedBuildFileExceptionSet section */
+
 /* Begin PBXFileSystemSynchronizedRootGroup section */
 		AE2AB2772F70DFFF402AA02B /* SyncedFolder */ = {
 			isa = PBXFileSystemSynchronizedRootGroup;
+			exceptions = (
+				"TEMP_067E2B5F-0F9F-4B71-A34B-DB4FEB8A01AC" /* PBXFileSystemSynchronizedBuildFileExceptionSet */,
+			);
 			explicitFileTypes = {
 			};
 			explicitFolders = (