Skip to content

Use USER env var instead of LOGNAME #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yonaskolb merged 1 commit into from
Jul 17, 2025
+1 −1
Merged

Use USER env var instead of LOGNAME #1559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/XcodeGenCLI/Commands/GenerateCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class GenerateCommand: ProjectCommand {
do {
let projectGenerator = ProjectGenerator(project: project)

guard let userName = ProcessInfo.processInfo.environment["LOGNAME"] else {
guard let userName = ProcessInfo.processInfo.environment["USER"] else {
Copy link
Copy Markdown
Owner

@yonaskolb yonaskolb Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't my area of expertise. Would this cover all bases?

Suggested change
guard let userName = ProcessInfo.processInfo.environment["USER"] else {
let environment = ProcessInfo.processInfo.environment
guard let userName = environment["USER"] ?? environment["LOGNAME"] ?? NSUserName() else {

Copy link
Copy Markdown
Contributor Author

@KostyaSha KostyaSha Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think USER always exists it's standart *nix variable

Copy link
Copy Markdown
Contributor Author

@KostyaSha KostyaSha Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw error is named GenerationError.missingUsername not GenerationError.missingLogname

Copy link
Copy Markdown
Contributor Author

@KostyaSha KostyaSha Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the goal of this check at all? Is it passed only for file owner for created files?

Copy link
Copy Markdown
Owner

@yonaskolb yonaskolb Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used to generate XCUserData

throw GenerationError.missingUsername
}

Expand Down