Expose the current source and destination paths to the replacement function#27
Open
tatablack wants to merge 1 commit into
Open
Expose the current source and destination paths to the replacement function#27tatablack wants to merge 1 commit into
tatablack wants to merge 1 commit into
Conversation
Owner
|
Hey just wanted to say sorry for the delays - have been particularly busy. Still going to be a little while before I can review and merge, there's a queue of pull requests so want to get through these at the same time. Thanks, Jonathan |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my use case, I was using the replacement function to manipulate the file text, and I needed to know which file I was editing (full path).
So I exposed the current file path and the current destination path in a way that makes them accessible to the replacement function without having to propagate them all the way down. Let me know if you think this is a suitable solution, or if you'd rather add an additional parameter and propagate it.
I added a note about it in the README.