Add worst case tests for fixed dlog.#1392
Merged
maspypy merged 2 commits intoApr 8, 2026
Merged
Conversation
Collaborator
|
I'll merge it, thank you! |
maspypy
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
big_safe_randomPohlig-Hellman algorithm can be quite effective in existing tests, even for precomputation. Safe primes provide the worst case for Pohlig-Hellman. Example hack, note the slightly longer precompute time of 14ms compared to 12ms in sample in stderr.
big_safe_random_g2Some solutions try to solve for discrete logarithm of$k$ via a reduction to $k, gk, g^2k, ...$ until one is "easy enough" to solve (e.g. when it's smooth or $k/p$ is very close to a fraction with a small denominator), treating this sequence as random. Such solutions will be slowed down when $g=2$ because if a particular value isn't suitable, twice that value is likely to not be suitable either.
Example of a solution being slower when$g=2$ because: