Added Windows editor arg quoting and git status refresh after worktree bootstrap

Adapted from upstream t3code #1805 and #2005. launchDetached now quotes each arg with
double quotes on Windows (shell: true) to handle paths with spaces. Added
refreshGitStatus call after worktree creation in wsBootstrap and after branch rename
in ProviderCommandReactorSessionOps. Updated ProviderCommandReactor test to include
GitStatusBroadcaster mock.

Author: youpele52

apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts

@@ -27,6 +27,10 @@ import {
   type ProviderServiceShape,
 } from "../../provider/Services/ProviderService.ts";
 import { GitCore, type GitCoreShape } from "../../git/Services/GitCore.ts";
+import {
+  GitStatusBroadcaster,
+  type GitStatusBroadcasterShape,
+} from "../../git/Services/GitStatusBroadcaster.ts";
 import { TextGeneration, type TextGenerationShape } from "../../git/Services/TextGeneration.ts";
 import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
 import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
@@ -180,6 +184,24 @@ describe("ProviderCommandReactor", () => {
             : "renamed-branch",
       }),
     );
+    const refreshLocalStatus = vi.fn((_: string) =>
+      Effect.succeed({
+        isRepo: true,
+        hasOriginRemote: true,
+        isDefaultBranch: false,
+        branch: "renamed-branch",
+        hasWorkingTreeChanges: false,
+        workingTree: {
+          files: [],
+          insertions: 0,
+          deletions: 0,
+        },
+        hasUpstream: true,
+        aheadCount: 0,
+        behindCount: 0,
+        pr: null,
+      }),
+    );
     const generateBranchName = vi.fn<TextGenerationShape["generateBranchName"]>((_) =>
       Effect.fail(
         new TextGenerationError({
@@ -235,6 +257,11 @@ describe("ProviderCommandReactor", () => {
         }),
       ),
       Layer.provideMerge(Layer.succeed(GitCore, { renameBranch } as unknown as GitCoreShape)),
+      Layer.provideMerge(
+        Layer.succeed(GitStatusBroadcaster, {
+          refreshLocalStatus,
+        } as unknown as GitStatusBroadcasterShape),
+      ),
       Layer.provideMerge(
         Layer.mock(TextGeneration, {
           generateBranchName,
@@ -290,6 +317,7 @@ describe("ProviderCommandReactor", () => {
       respondToUserInput,
       stopSession,
       renameBranch,
+      refreshLocalStatus,
       generateBranchName,
       generateThreadTitle,
       stateDir,

apps/server/src/utils/open.ts

@@ -293,11 +293,16 @@ export const launchDetached = (launch: EditorLaunch) =>
     yield* Effect.callback<void, OpenError>((resume) => {
       let child;
       try {
-        child = spawn(launch.command, [...launch.args], {
-          detached: true,
-          stdio: "ignore",
-          shell: process.platform === "win32",
-        });
+        const isWin32 = process.platform === "win32";
+        child = spawn(
+          launch.command,
+          isWin32 ? launch.args.map((a) => `"${a}"`) : [...launch.args],
+          {
+            detached: true,
+            stdio: "ignore",
+            shell: isWin32,
+          },
+        );
       } catch (error) {
         return resume(
           Effect.fail(new OpenError({ message: "failed to spawn detached process", cause: error })),

apps/server/src/ws/ws.ts

@@ -109,15 +109,21 @@ const WsRpcLayer = WsRpcGroup.toLayer(
             cause,
           });
 
+    const refreshGitStatusEffect = (cwd: string) =>
+      gitManager.invalidateStatus(cwd).pipe(
+        Effect.flatMap(() => gitStatusBroadcaster.invalidateLocal(cwd)),
+        Effect.flatMap(() => gitStatusBroadcaster.invalidateRemote(cwd)),
+      );
+
     const dispatchBootstrapTurnStart = makeDispatchBootstrapTurnStart(
       orchestrationEngine,
       git,
       projectSetupScriptRunner,
+      refreshGitStatusEffect,
       appendSetupScriptActivity,
       serverCommandId,
     );
 
-    /** Fire-and-forget helper to invalidate + re-broadcast git status for a cwd. */
     const refreshGitStatus = (cwd: string) =>
       gitManager.invalidateStatus(cwd).pipe(
         Effect.flatMap(() => gitStatusBroadcaster.invalidateLocal(cwd)),

apps/server/src/ws/wsBootstrap.ts

@@ -36,12 +36,14 @@ export type BootstrapServices = {
       input: ProjectSetupScriptRunnerInput,
     ) => Effect.Effect<ProjectSetupScriptRunnerResult, Error>;
   };
+  readonly refreshGitStatus: (cwd: string) => Effect.Effect<void>;
 };
 
 export function makeDispatchBootstrapTurnStart(
   orchestrationEngine: BootstrapServices["orchestrationEngine"],
   git: BootstrapServices["git"],
   projectSetupScriptRunner: BootstrapServices["projectSetupScriptRunner"],
+  refreshGitStatus: BootstrapServices["refreshGitStatus"],
   appendSetupScriptActivity: (input: {
     readonly threadId: ThreadId;
     readonly kind: "setup-script.requested" | "setup-script.started" | "setup-script.failed";
@@ -197,6 +199,7 @@ export function makeDispatchBootstrapTurnStart(
             branch: worktree.worktree.branch,
             worktreePath: targetWorktreePath,
           });
+          yield* refreshGitStatus(targetWorktreePath).pipe(Effect.ignoreCause({ log: true }));
         }
 
         yield* runSetupProgram();