Improve error handling and logging for removing old snapshots

Author: Istrate Andrei-Eduard

src/main.rs

@@ -62,7 +62,6 @@ fn merge_global_store(
 #[actix_web::main]
 async fn main() -> std::io::Result<()> {
     dotenvy::dotenv().unwrap();
-    // Usage: <program> <current_node_address> [join_node_address]
     let args: Vec<String> = env::args().collect();
     if args.len() < 2 {
         eprintln!("Usage: {} <current_node_address> [join_node_address]", args[0]);
@@ -86,7 +85,6 @@ async fn main() -> std::io::Result<()> {
     });
     let _ = APP_STATE.set(state.clone());
 
-    // Load cold storage (snapshot + WAL replay) from disk.
     match load_all_tables(&state).await {
         Ok(_) => println!("Cold storage loaded"),
         Err(e) => eprintln!("Error loading cold storage: {}", e),
@@ -115,7 +113,7 @@ async fn main() -> std::io::Result<()> {
 
         // Send join request.
         let client = reqwest::Client::new();
-        let join_url = format!("http://{}/join", join_node);
+        let join_url = format!("{}/join", join_node);
         match client
             .post(&join_url)
             .json(&json!({
@@ -143,7 +141,7 @@ async fn main() -> std::io::Result<()> {
 
 
         // Pull the remote state for all tables.
-        let store_url = format!("http://{}/store", join_node);
+        let store_url = format!("{}/store", join_node);
         match client.get(&store_url).header("x-api-key", std::env::var("CLUSTER_SECRET").unwrap_or_default()).send().await {
             Ok(resp) => {
                 if resp.status().is_success() {

src/storage/snapshoting.rs

@@ -1,4 +1,5 @@
 use actix_web::web::Data;
+use log::warn;
 use serde_json;
 use std::{env, io, path::PathBuf, time::SystemTime};
 use tokio::{fs, time::{self, Duration}};
@@ -35,7 +36,10 @@ async fn clean_old_snapshots(dir: &PathBuf, max_snapshots: usize)
             .into_iter()
             .take(snaps_cloned.len() - max_snapshots)
         {
-            let _ = fs::remove_file(old).await;
+            match fs::remove_file(&old).await {
+                Ok(_) => { println!("Removed old snapshot from path: {}", old.to_str().unwrap())},
+                Err(error) => {warn!("{:}", error)}
+            };
         }
     }
     Ok(())
@@ -62,7 +66,7 @@ pub fn start_snapshot_task(states: &Data<AppState>) {
             return;
         }
 
-        let mut ticker = time::interval(Duration::from_secs(60 * 60));
+        let mut ticker = time::interval(Duration::from_secs(3600));
         loop {
             ticker.tick().await;
             let ts = current_timestamp();